search

workfloworchestrator / orchestrator-ui-library

Component library for the orchestrator-ui (v2) which is published in npm
6 stars 3 forks source link

Configurable OAuth Scopes via Environment Variables #1056

Closed torkashvand closed 2 weeks ago

torkashvand commented 3 weeks ago

Issue: The authorization scopes for OAuth are currently hardcoded in the NextAuth.js configuration, limiting operational flexibility across different environments.

Link to the issue: https://github.com/workfloworchestrator/orchestrator-ui-library/issues/1055

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: 47ce8ff115082ef3a6ccb30759193ad5f129186b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------------------------------------------- | ----- | | @orchestrator-ui/orchestrator-ui-components | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ricardovdheijden commented 2 weeks ago

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

torkashvand commented 2 weeks ago

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

Thanks, I will apply your suggestion but first I need to create another PR for my first PR on the submodule repo which has been merged.

I will add you as a reviewer on that PR as well.

ricardovdheijden commented 2 weeks ago

Thank you for contributing to our project. I made one suggestion, see comment. Also I will add a changesetfile to this PR.

Thanks, I will apply your suggestion but first I need to create another PR for my first PR on the submodule repo which has been merged.

I will add you as a reviewer on that PR as well.

Yes, will have a look then. Also I just added a commit to your branch/PR. It contains a changeset file for collecting release notes for publishing to NPM.

torkashvand commented 2 weeks ago

@ricardovdheijden Thanks for approving my PR. I think it needs two approves. correct?

ricardovdheijden commented 2 weeks ago

@ricardovdheijden Thanks for approving my PR. I think it needs two approves. correct?

Yes indeed, added some reviewers