module updates not sent between app instances (module positions)

[michaelpalumbo]

2 causes identified:

1. module position/quat is being modified directly, and that app.js is not reading module position values from the patch.document. seems this would need to change in order for incoming module position values to take effect:

// approx line 541 
// apply hand pose to the dragged object:
let m = mat4.multiply(mat4.create(), hand.mat, hand.stateData.objectRelativeMat);
mat4.getTranslation(object.pos, m)
mat4.getRotation(object.quat, m)

2. the position array for a given module is being updated prior to this.document being modified by Automerge in patch.update(). Therefore, sync messages are not being generated for position updates (because according to automerge, nothing has changed). This one is weird, it's not clear to me why/where this is happening

update: cause 1 is fixed for position data (will repeat solution for quat once cause 2 is fixed)

update 2: a possible solution may be to change the position property for modules from an array to an object with x, y, and z properties. reasoning: automerge sync protocol is funky with detecting changes made to lists.

[michaelpalumbo]

see branch bug/positions

[michaelpalumbo]

findings:

• peer scene does not get rebuilt when position/quat are updated from a remote peer.
• while parameters are being changed by remote peer, other peers wait to rebuild their scene only once the params have stopped updating (perhaps once the controller lets go of the knob). this is a major issue, as players won't see knobs turned nor hear the result of these changes in real-time
• curiously, both of these issues are related to the update method in Patch.js

[michaelpalumbo]

to do:

• [x] does peer receive a message that remote has changes a module's position?
• [x] trigger rebuild when receiving positional/quat data changes
• [x] trigger rebuild when receiving parameter updates
• [x] confirm that remote hears the parameter updates

[michaelpalumbo]

this is fixed now. however note that Automerge sync protocol was not able to detect changes to arrays (lists), see https://github.com/automerge/automerge/issues/760