wso2 / istio-apim

Apache License 2.0
65 stars 17 forks source link

This is a TCP liveness probe #15

Open errge opened 5 years ago

errge commented 5 years ago

Hey guys, I'm from today's APIdays Zurich workshop. These nc -z probes seem equivalent to a TCP probe (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/#define-a-tcp-liveness-probe)

I maybe missing something, but may worth a look.

https://github.com/wso2/istio-apim/blob/ae529a841d7593498dc362afd4dc64c0df9bf2b0/install/analytics/k8s-artifacts/wso2apim-analytics-deployment.yaml#L48

pubudu538 commented 5 years ago

Hi Errge,

Thank you for reporting the issue. Yes, we should be able to use the tcp probes. Will check that approach as well.

Thank you! Pubudu.