search

wtekiela / opensub4j

Java library for communicating with opensubtitles.org XML-RPC API
Other
48 stars 19 forks source link

Search subtitles with series imdb id, season number and episode number is not correct #24

Closed arrajeev87 closed 3 years ago

arrajeev87 commented 3 years ago

When I use the search subtitles method with query and season and episode number I get the proper result however if I pass the series Imdb id instead of query with season and episode numbers I get all subtitle info for the complete series and that particular episode.

I have done the required changes for this in my local branch with some few more fields added in the SubtitleInfo pojo which I would like to have.

I would really appreciate if you can accept these changes.

wtekiela commented 3 years ago

Hi @arrajeev87 , can you open a PR for that? Thanks

arrajeev87 commented 3 years ago

Have opened a pull request.

Thanks

arrajeev87 commented 3 years ago

Hi @wtekiela need your help to merge the PR. I am trying to integrate with Open Subtitles and having this changes in place will help me a lot.

Thanks in Advance

wtekiela commented 3 years ago

Hi @arrajeev87 thanks for submitting the PR, will have a look at it this evening CEST

wtekiela commented 3 years ago

Fixed in master in #25 and cherry-picked into 0.3 branch in commit 088b53131746c43d1eb2e6e987069f5fc5b48beb

wtekiela commented 3 years ago

released 0.3.2 with this improvement