Fixing subtitle search for episode with series imdb id and adding few more fields in SubtitleInfo

wtekiela / opensub4j

Java library for communicating with opensubtitles.org XML-RPC API

Other

47 stars 19 forks source link

Fixing subtitle search for episode with series imdb id and adding few more fields in SubtitleInfo #25

Closed arrajeev87 closed 3 years ago

arrajeev87 commented 3 years ago

I have added the below there fields in SubtitleInfo,

imdbId: In case I search from a query or fetch episode subtitle from series imdb id I would like to know the imdb id of the content
subtitleSize: Will help me to pick the largest file size subtitle as that is my requirement
subtitleRating: Will help me evaluate the quality of the subtitle before I download them

arrajeev87 commented 3 years ago

Hi @wtekiela the integration test is failing as username and password is not getting passed. Can you help me here?

wtekiela commented 3 years ago

Hmm, weird that it failed, the username and password are hardcoded and secured in travis.yml file (master and 0.3 branches do work in travis). Will have a look in a bit.

In the meatime you can try manually running integ tests by:

OS_USER=[secure] OS_PASS=[secure]  ./gradlew clean check --info

arrajeev87 commented 3 years ago

Thanks a lot! 👍