search

wuwanahq / wuwana2

🇪🇺 Wuwana v2 - A webapp to help users find local suppliers in Spain.
Mozilla Public License 2.0
2 stars 2 forks source link

Store Instagram pictures #179

Closed Nils85 closed 3 years ago

Nils85 commented 3 years ago

We currently rely on Instagram static servers to display all pictures from Instagram. The problem is these image links are temporary and when they are outdated or if the user delete it our profile page becomes completely broken. Same for the company logo...

So instead of just storing links after scraping a profile we should download each picture from the link then keep them on our server until the next profile update.

Nils85 commented 3 years ago

@levogirar You should remove all JavaScript code that replace missing images by the Wuwana logo in main.js with your next pull request

levogirar commented 3 years ago

I am not sure storing the pictures is a good solution.

We can set this to cycle 6 #177 where we will focus on Instagram, Instagram, and Google. We can have develop-v22 public and start the new develop branch

Nils85 commented 3 years ago

Wouldn't it cause us more problem with Instagram? I think following Google Images style would be better (do they store the picture in their servers?)

Technically it is way better for the website in order to becomes more stable. But legally it is definitely worst. 😅 Google Image never display pictures from Instagram and for others websites they do like us with a direct link from the origin website.

I think this is only a problem because we do not update the companies frequently enough. A weekly link scraping should prevent this problem.

Not really because we are 100% dependent of Instagram servers. The moment we get blocked, whatever the update frequency is, we have to wait until Instagram decides to allow us to continue a little bit. And this is not going to improve with time because imagine in the future when we will have to update thousands of companies... So don't hope to have profile pages up to date with so many requests pending on Instagram.

We can set this to cycle 6 #177 where we will focus on Instagram, Instagram, and Google. We can have develop-v22 public and start the new develop branch

Ok but we have to know which path we are taking now:

Nils85 commented 3 years ago

This is not a good solution. See related issue #183