Open meghapatnaik opened 11 months ago
ayushpatnaikgit
commented
11 months ago Can you point to the lines that need to be changed? GitHub allows you to hyperlink a line, for example: https://github.com/xKDR/Karmana.jl/blob/e0398ade5c656ddf1adf62b47c3e976e2870ba50/src/Karmana.jl#L7
meghapatnaik
commented
11 months ago I cannot seem to hyperlink lines from pull requests that have not been approved (can you do the above for any line of read_nl.jl?).
I suggest we approve pull request #41 in entirety. lines 1-7 and line 20 in read_nl.jl and the corresponding change suggested in line 41 Karmana.jl to include read_nl.jl will solve the issue described.
To construct a radiance datacube, we may wish to use readdir() on a folder containing a series of consecutive monthly files. If readdir() produces chronologically ordered files, this will construct the correctly sequenced datacube. However, it is better to replace readdir() with readdir_nl(), which can extract the timestamp from the filename directly. Since night light files from EOG are sequenced as "sensor_satellitenametimestamp ...", in any instance a different satellite source is used for a monthly image, there will be no disruption in chronological ordering. Function that can be used to extract the date:
get_date_from_filename(filename) = Date(parse(Int, match(r"\d{8}", filename).match))
A similar solution has been proposed in pull request #41