xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.62k stars 1.87k forks source link

[Bug] Regression: FontIcon rendering quality decreased (UWP) #10538

Open CleanCodeDeveloper opened 4 years ago

CleanCodeDeveloper commented 4 years ago

Description

FontIcons rendering quality in AppShell Flyout decreased with Xamarin.Forms v4.6.0.726 compared to previous version v4.5.0.657 or v4.5.0.725

Steps to Reproduce

  1. Define FontImageSource in ResourceDictionary

    <ResourceDictionary>
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE80F;" Color="Black" x:Key="IconHomeFlyout"/>
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE713;" Color="Black" x:Key="IconSettingsFlyout"/>
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE946;" Color="Black" x:Key="IconAboutFlyout"/>
    
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE80F;" x:Key="IconHome"/>
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE713;" x:Key="IconSettings"/>
    <FontImageSource FontFamily="Segoe MDL2 Assets" Glyph="&#xE946;" x:Key="IconAbout"/>
    </ResourceDictionary>
  2. Use the FontIcon in an ShellItem

    
    <ShellItem Title="{x:Static localization:AppResources.PageName_Settings}" Route="settings" 
               Icon="{StaticResource IconSettings}" FlyoutIcon="{StaticResource IconSettingsFlyout}">
    <views:SettingsPage Title="Settings"/>
    </ShellItem>

<ShellItem Title="{x:Static localization:AppResources.PageName_About}" Route="about" Icon="{StaticResource IconAbout}" FlyoutIcon="{StaticResource IconAboutFlyout}">



### Expected Behavior / Actual Behavior
![image](https://user-images.githubusercontent.com/16760760/80860812-8b513b00-8c6a-11ea-8774-351c3bd21440.png)

### Basic Information

- Version with issue: v4.6.0.726, v4.6.0.800, 4.7.0.813-pre2
- Last known good version: v4.5.0.725
- IDE: VS 2019 (v16.6.0 Preview 5) 
- Platform Target Frameworks: 
  - UWP:  10.0.18362.0

### Screenshots
See above

### Reproduction Link
[FontIconRenderingQuality10538.zip](https://github.com/xamarin/Xamarin.Forms/files/4605533/FontIconRenderingQuality10538.zip)

### Workaround
None
StephaneDelcroix commented 4 years ago

does this happens only in a shell item ? or elsewhere too ? could you please provide a reproduction sample ? thanks

CleanCodeDeveloper commented 4 years ago

The bug occurs only in the Flyout of the ShellItem.

I've create a small reproduction sample: FontIconRenderingQuality10538.zip

CleanCodeDeveloper commented 4 years ago

@StephaneDelcroix: Is the repro I added sufficient?