search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.64k stars 1.88k forks source link

[Enhancement] Introduce a new FlyoutDisplayOptions on Shell "DisplayAsChildren" #13274

Open davidbuckleyni opened 3 years ago

davidbuckleyni commented 3 years ago

Description

When I enable FlyoutDisplayOptions="AsMultipleItems" the main menu item disappears and the sub menu items do not appear indentent. This is because "AsMultipleItems" is just used to create groups based on different FlyoutItems but doesn't cause nesting of items. To enable the ability to nest FlyoutItems we should look at introducing an option FlyoutDisplayOptions="DisplayAsChildren" that show the items as nested.

Steps to Reproduce

  1. Create a standard xamrain.forms shell project

  2. Add the following to a AppShell.Xaml

    <FlyoutItem Title="Addons"  FlyoutDisplayOptions="AsMultipleItems" x:Name="addonsflayout" Icon="icon_about.png">
    <ShellContent Route="AddonsPage" ContentTemplate="{DataTemplate local:AddonsPage}" />
</FlyoutItem>

  3. In AppShell.Xaml Place the following code 

    
addonsflayout.Items.Add(new ShellContent {
        Title = "Airliners",
        Icon = "tab_about",
        Content = new AboutPage()
});

 addonsflayout.Items.Add(new ShellContent    {
        Title = "Piston Planes",
        Icon = "tab_about",
        Content = new AboutPage()
});
 addonsflayout.Items.Add(new ShellContent    {
        Title = "Turbo Props",
        Icon = "tab_about",
        Content = new AboutPage()
    });

### Expected Behavior
The items should appear under the menu item addons and be idented and not appear on the bottom bar.

### Actual Behaviour
The items appear inline and not indentend and the main menu item addons is removed from view.

![image](https://user-images.githubusercontent.com/5619229/103516993-546e9d00-4e69-11eb-9d1a-9d320975419b.png)

They also appear on bottom bar when should not 

![image](https://user-images.githubusercontent.com/5619229/103517029-62bcb900-4e69-11eb-9605-ec525b8414b2.png)

### Basic Information
Microsoft Visual Studio Community 2019
Version 16.8.3
VisualStudio.16.Release/16.8.3+30804.86
Microsoft .NET Framework
Version 4.8.04084

Installed Version: Community

Visual C++ 2019   00435-60000-00000-AA994
Microsoft Visual C++ 2019

ASP.NET and Web Tools 2019   16.8.554.20160
ASP.NET and Web Tools 2019

ASP.NET Core Razor Language Services   16.1.0.2052803+84e121f1403378489b842e1797df2f3f5a49ac3c
Provides languages services for ASP.NET Core Razor.

ASP.NET Web Frameworks and Tools 2019   16.8.554.20160
For additional information, visit https://www.asp.net/

Azure App Service Tools v3.0.0   16.8.554.20160
Azure App Service Tools v3.0.0

Azure Functions and Web Jobs Tools   16.8.554.20160
Azure Functions and Web Jobs Tools

C# Tools   3.8.0-5.20604.10+9ed4b774d20940880de8df1ca8b07508aa01c8cd
C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Common Azure Tools   1.10
Provides common services for use by Azure Mobile Services and Microsoft Azure Tools.

Extensibility Message Bus   1.2.6 (master@34d6af2)
Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration.

IntelliCode Extension   1.0
IntelliCode Visual Studio Extension Detailed Info

JetBrains ReSharper 2020.3.1   Build 203.0.20201223.80701
JetBrains ReSharper package for Microsoft Visual Studio. For more information about ReSharper, visit http://www.jetbrains.com/resharper. Copyright © 2021 JetBrains, Inc.

Markdown Editor   1.12.253
A full featured Markdown editor with live preview and syntax highlighting. Supports GitHub flavored Markdown.

Microsoft Azure Tools   2.9
Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.30924.1

Microsoft Continuous Delivery Tools for Visual Studio   0.4
Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE.

Microsoft JVM Debugger   1.0
Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines

Microsoft Library Manager   2.1.113+g422d40002e.RR
Install client-side libraries easily to any web project

Microsoft MI-Based Debugger   1.0
Provides support for connecting Visual Studio to MI compatible debuggers

Microsoft Visual C++ Wizards   1.0
Microsoft Visual C++ Wizards

Microsoft Visual Studio Tools for Containers   1.1
Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container.

Microsoft Visual Studio VC Package   1.0
Microsoft Visual Studio VC Package

Mono Debugging for Visual Studio   16.8.43 (00471f8)
Support for debugging Mono processes with Visual Studio.

NuGet Package Manager   5.8.0
NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/

ProjectServicesPackage Extension   1.0
ProjectServicesPackage Visual Studio Extension Detailed Info

SQL Server Data Tools   16.0.62010.06180
Microsoft SQL Server Data Tools

TypeScript Tools   16.0.21016.2001
TypeScript Tools for Microsoft Visual Studio

Visual Basic Tools   3.8.0-5.20604.10+9ed4b774d20940880de8df1ca8b07508aa01c8cd
Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used.

Visual F# Tools   16.8.0-beta.20507.4+da6be68280c89131cdba2045525b80890401defd
Microsoft Visual F# Tools

Visual Studio Code Debug Adapter Host Package   1.0
Interop layer for hosting Visual Studio Code debug adapters in Visual Studio

Visual Studio Container Tools Extensions   1.0
View, manage, and diagnose containers within Visual Studio.

Visual Studio Tools for Containers   1.0
Visual Studio Tools for Containers

Visual Studio Tools for Unity   4.8.2.0
Visual Studio Tools for Unity

VisualStudio.DeviceLog   1.0
Information about my package

VisualStudio.Foo   1.0
Information about my package

VisualStudio.Mac   1.0
Mac Extension for Visual Studio

Xamarin   16.8.000.260 (d16-8@fd405a2)
Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android.

Xamarin Designer   16.8.0.507 (remotes/origin/d16-8@e87b24884)
Visual Studio extension to enable Xamarin Designer tools in Visual Studio.

Xamarin Templates   16.8.112 (86385a3)
Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms.

Xamarin.Android SDK   11.1.0.17 (d16-8/c0e2b8e)
Xamarin.Android Reference Assemblies and MSBuild support.
    Mono: be2226b
    Java.Interop: xamarin/java.interop/d16-8@79d9533
    ProGuard: Guardsquare/proguard/proguard6.2.2@ebe9000
    SQLite: xamarin/sqlite/3.32.1@1a3276b
    Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-8@2fb1cbc

Xamarin.iOS and Xamarin.Mac SDK   14.6.0.15 (87a1b18d8)
Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support.
PureWeen commented 3 years ago

@davidbuckleyni can you try the latest nightly? https://github.com/xamarin/Xamarin.Forms/wiki/Nightly-Builds

davidbuckleyni commented 3 years ago

@davidbuckleyni can you try the latest nightly? https://github.com/xamarin/Xamarin.Forms/wiki/Nightly-Builds

Will do just using the same code ?

davidbuckleyni commented 3 years ago

Hi @PureWeen I thought u jumped ship I tried it on the nightly build still the same result as you see my sub items are shown below on the tab bar instead of in the menu where they should be

image Surely a sub menu item should be below add ons with an indentation

image

As you see this is off the night build

image

PureWeen commented 3 years ago

@davidbuckleyni updated the ticket based on our conversation

Let me know if what I've articulated seems incorrect

davidbuckleyni commented 3 years ago

Yeah that seems spot on @PureWeen looking forward to the launch party later today.