search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.62k stars 1.87k forks source link

[Bug] Crash when setting Application.Current.UserAppTheme #14041

Open stesvis opened 3 years ago

stesvis commented 3 years ago

Description

I have a settings page that allows users to change the theme from Light/Dark etc. Often times when I save the change and the app reloads the views, it crashes.

Steps to Reproduce

Application.Current.UserAppTheme = OSAppTheme.Light;
await NavigationService.GoBackAsync(); // uses Prism MVVM

Expected Behavior

The app refreshes the views with the new theme colors

Actual Behavior

System.ObjectDisposedException: 'Cannot access a disposed object. Object name: 'Xamarin.Forms.Platform.Android.Platform+DefaultRenderer'.'

Thread started: #20 [AppCenterCrashes] at Android.Views.View.SetBackgroundColor (Android.Graphics.Color color) [0x0001e] in /Users/builder/azdo/_work/278/s/xamarin-android/src/Mono.Android/obj/Release/monoandroid10/android-29/mcw/Andro03-21 11:48:37.775 E/AppCenterCrashes(22971): Unhandled Exception from source=AndroidEnvironment [AppCenterCrashes] System.ObjectDisposedException: Cannot access a disposed object. [AppCenterCrashes] Object name: 'Xamarin.Forms.Platform.Android.Platform+DefaultRenderer'. [AppCenterCrashes] at Java.Interop.JniPeerMembers.AssertSelf (Java.Interop.IJavaPeerable self) [0x00029] in <94b04e1756104d1fa1d144932ae2720c>:0 [AppCenterCrashes] at Java.Interop.JniPeerMembers+JniInstanceMethods.InvokeVirtualVoidMethod (System.String encodedMember, Java.Interop.IJavaPeerable self, Java.Interop.JniArgumentValue* parameters) [0x00000] in <94b04e1756104d1fa1d144932ae2720c>:0 [AppCenterCrashes] at Android.Views.View.SetBackgroundColor (Android.Graphics.Color color) [0x0001e] in /Users/builder/azdo/_work/278/s/xamarin-android/src/Mono.Android/obj/Release/monoandroid10/android-29/mcw/Android.Views.View.cs:19885 [AppCenterCrashes] at Xamarin.Forms.Platform.Android.VisualElementRenderer1[TElement].UpdateBackgroundColor () [0x00000] in D:\a\1\s\Xamarin.Forms.Platform.Android\VisualElementRenderer.cs:491 [AppCenterCrashes] at Xamarin.Forms.Platform.Android.VisualElementRenderer1[TElement].OnElementPropertyChanged (System.Object sender, System.ComponentModel.PropertyChangedEventArgs e) [0x00017] in D:\a\1\s\Xamarin.Forms.Platform.Android\VisualElementRenderer.cs:368 [AppCenterCrashes] at (wrapper delegate-invoke) .invoke_void_object_PropertyChangedEventArgs(object,System.ComponentModel.PropertyChangedEventArgs) [AppCenterCrashes] at Xamarin.Forms.Element.OnPropertyChanged (System.Stri03-21 11:48:37.775 E/AppCenterCrashes(22971): at Xamarin.Forms.BindableObject.OnPropertyChanged (System.String propertyName) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:266 [AppCenterCrashes] at Xamarin.Forms.Element.OnPropertyChanged (System.String propertyName) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\Element.cs:362 [AppCenterCrashes] at Xamarin.Forms.BindableObject.SetValueActual (Xamarin.Forms.BindableProperty property, Xamarin.Forms.BindableObject+BindablePropertyContext context, System.Object value, System.Boolean currentlyApplying, Xamarin.Forms.Internals.SetValueFlags attributes, System.Boolean silent) [0x00114] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:510 [AppCenterCrashes] at Xamarin.Forms.BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes, Xamarin.Forms.BindableObject+SetValuePrivateFlags privateAttributes) [0x00173] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:446 [AppCenterCrashes] at Xamarin.Forms.BindableObject.SetValueCore (Xamarin.Forms.BindableProperty property, System.Object value, Xamarin.Forms.Internals.SetValueFlags attributes) [0x00000] in D:\a\1\s\Xamarin.Forms.Core\BindableObject.cs:383 [AppCenterCrashes] at Xamarin.Forms.AppThemeBinding.ApplyCore () [0x00018] in D:\a\1\s\Xamarin.Forms.Core\AppThemeBinding.cs:47 [AppCenterCrashes] at Xamarin.Forms.AppThemeBinding.<.ctor>b2_1 () [0x00000] in D:\a\1\s\Xamarin.Forms.Core\AppThemeBinding.cs:10 [AppCenterCrashes] at Java.Lang.Thread+RunnableImplementor.Run () [0x00008] in /Users/builder/azdo/_work/278/s/xamarin-android/src/Mono.Android/Java.Lang/Thread.cs:36 [AppCenterCrashes] at Java.Lang.IRunnableInvoker.n_Run (System.IntPtr jnienv, System.IntPtr native__this) [0x00008] in /Users/builder/azdo/_work/278/s/xamarin-android/src/Mono.Android/obj/Release/monoandroid10/android-29/mcw/Java.Lang.IRunnable.cs:84 [AppCenterCrashes] at (wrapper dynamic-method) Android.Runtime.DynamicMethodNameCounter.27(intptr,intptr) [Mono] Requesting loading reference 5 (of 6) of /data/data/ca.levitica.yourent/files/.override/Microsoft.AppCenter.Crashes.dll [Mono] Loading reference 5 of /data/data/ca.levitica.yourent/files/.override__/Microsoft.AppCenter.Crashes.dll asmctx DEFAULT, looking for System.Core, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e

[Mono] DllImport searching in: '__Internal' ('(null)'). [Mono] Searching for 'java_interop_jnienv_throw'. [Mono] Probing 'java_interop_jnienv_throw'. [Mono] Found as 'java_interop_jnienv_throw'. System.ObjectDisposedException: 'Cannot access a disposed object. Object name: 'Xamarin.Forms.Platform.Android.Platform+DefaultRenderer'.'

Basic Information

Environment

Show/Hide Visual Studio info ``` Microsoft Visual Studio Community 2019 Version 16.9.2 VisualStudio.16.Release/16.9.2+31112.23 Microsoft .NET Framework Version 4.8.04084 Installed Version: Community Visual C++ 2019 00435-60000-00000-AA518 Microsoft Visual C++ 2019 ASP.NET and Web Tools 2019 16.9.688.6828 ASP.NET and Web Tools 2019 ASP.NET Core Razor Language Services 16.1.0.2112521+5741df381174d72f08e3632bb99f52e8635b6a1a Provides languages services for ASP.NET Core Razor. ASP.NET Web Frameworks and Tools 2019 16.9.688.6828 For additional information, visit https://www.asp.net/ Azure App Service Tools v3.0.0 16.9.688.6828 Azure App Service Tools v3.0.0 Azure Functions and Web Jobs Tools 16.9.688.6828 Azure Functions and Web Jobs Tools C# Tools 3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3 C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. CleanBinAndObjCommand Extension 1.1.1 CleanBinAndObjCommand Visual Studio Extension Detailed Info CodeMaid 11.2.231 CodeMaid is an open source Visual Studio extension to cleanup and simplify our C#, C++, F#, VB, PHP, PowerShell, R, JSON, XAML, XML, ASP, HTML, CSS, LESS, SCSS, JavaScript and TypeScript coding. CommandJSON2CSharp Extension 1.0 CommandJSON2CSharp Visual Studio Extension Detailed Info Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools. Extensibility Message Bus 1.2.6 (master@34d6af2) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration. IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.40218.1 Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE. Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines Microsoft Library Manager 2.1.113+g422d40002e.RR Install client-side libraries easily to any web project Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers Microsoft Visual C++ Wizards 1.0 Microsoft Visual C++ Wizards Microsoft Visual Studio Tools for Containers 1.1 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container. Microsoft Visual Studio VC Package 1.0 Microsoft Visual Studio VC Package Mono Debugging for Visual Studio 16.9.7 (df23ba6) Support for debugging Mono processes with Visual Studio. NuGet Package Manager 5.9.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/ PowerShell Pro Tools for Visual Studio 1.0 A set of tools for developing and debugging PowerShell scripts and modules in Visual Studio. Productivity Power Tools 2017/2019 16.0 Installs the individual extensions of Productivity Power Tools 2017/2019 ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info SQL Server Data Tools 16.0.62103.10080 Microsoft SQL Server Data Tools StylerPackage Extension 1.0 StylerPackage Visual Stuido Extension Detailed Info Syncfusion Xamarin Project Templates 13.4.0.53 A multi-project template for building iOS, Android, and Windows apps using Syncfusion Xamarin components. Syncfusion Xamarin Toolbox 16.2.0.19 Syncfusion Essential Studio for Xamarin Toolbox Visual Studio extension. SyncfusionMenu Extension 1.0 SyncfusionMenu Visual Studio Extension Detailed Info TGit 1.0 Control TortoiseGit from within Visual Studio TypeScript Tools 16.0.30201.2001 TypeScript Tools for Microsoft Visual Studio Visual Basic Tools 3.9.0-6.21160.10+59eedc33d35754759994155ea2f4e1012a9951e3 Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Visual F# Tools 16.9.0-beta.21102.9+7ce7132f1459095e635194d09d6f73265352029a Microsoft Visual F# Tools Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio Visual Studio Container Tools Extensions 1.0 View, manage, and diagnose containers within Visual Studio. Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers VisualStudio.DeviceLog 1.0 Information about my package VisualStudio.Foo 1.0 Information about my package VisualStudio.Mac 1.0 Mac Extension for Visual Studio VSColorOutput 2.73 Color output for build and debug windows - https://mike-ward.net/vscoloroutput Xamarin 16.9.000.273 (d16-9@1bba9e0) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android. Xamarin Designer 16.9.0.316 (remotes/origin/d16-9@fdbf64026) Visual Studio extension to enable Xamarin Designer tools in Visual Studio. Xamarin Templates 16.9.68 (8e9b569) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms. Xamarin.Android SDK 11.2.2.1 (d16-9/877f572) Xamarin.Android Reference Assemblies and MSBuild support. Mono: 5e9cb6d Java.Interop: xamarin/java.interop/d16-9@54f8c24 ProGuard: Guardsquare/proguard/v7.0.1@912d149 SQLite: xamarin/sqlite/3.34.1@daff8f4 Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-9@d210f11 Xamarin.iOS and Xamarin.Mac SDK 14.14.2.5 (3836759d4) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support. ```
holecekp commented 3 years ago

This is probably the same bug that I have reported before: https://github.com/xamarin/Xamarin.Forms/issues/11704. There is also a repro project (https://github.com/xamarin/Xamarin.Forms/issues/11704#issuecomment-671094025) and the issue has an i/high flag, but it is still open. The crashes are random and, unfortunatelly, there is no worakround.

jsuarezruiz commented 3 years ago

Seems to be the same (or related) as #11704

stesvis commented 3 years ago

Seems to be the same (or related) as #11704

Yes, seems the same. Plus it happens to me also when I switch from dark to light, not only from light to dark.

PlaysafePP commented 1 year ago

2 years later and this bug is still open and occuring for me too. I have the latest of everything available to me at this time

image

This bug is still open. Is anyone likely to look at it? As there is no workaround offered, am wondering what I should tell my manager and our customers? Do I need to remove theme switching support?