search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.64k stars 1.88k forks source link

[Bug] Picker disabled text color cannot be changed and pickers do not respect VisualStateManager CommonStates #14525

Open ahoke-cr opened 3 years ago

ahoke-cr commented 3 years ago

Description

Unlike the Button, which is well-documented and fully-featured surrounding customizing various control states, the Picker, DatePicker, and TimePicker controls do not allow customizing visual state using VisualStateManager VisualStateGroups, which means that the controls cannot have additional styles applied depending on the state of the control.

If my application allows selection of a light or dark theme independent of the system theme, I can change the enabled text color to match the selected app theme; however, once a picker is disabled, the text color defaults to the system default color.

Steps to Reproduce

  1. Create a Picker and set a dark background color on the page.
  2. Ensure the device or emulator system theme is set to light theme.
  3. Disable the Picker
  4. Run the app and observe the black text that cannot be customized.

Expected Behavior

The disabled text color should be customizable independent of the system theme.

Actual Behavior

The disabled text color is not customizable and is tightly coupled to the system theme regardless of the app theme.

Basic Information

Environment

Show/Hide Visual Studio info ``` Microsoft Visual Studio Enterprise 2019 Version 16.10.3 VisualStudio.16.Release/16.10.3+31424.327 Microsoft .NET Framework Version 4.8.04084 Installed Version: Enterprise ADL Tools Service Provider 1.0 This package contains services used by Data Lake tools ASA Service Provider 1.0 ASP.NET and Web Tools 2019 16.10.526.50910 ASP.NET and Web Tools 2019 ASP.NET Web Frameworks and Tools 2019 16.10.526.50910 For additional information, visit https://www.asp.net/ Azure App Service Tools v3.0.0 16.10.526.50910 Azure App Service Tools v3.0.0 Azure Data Lake Node 1.0 This package contains the Data Lake integration nodes for Server Explorer. Azure Data Lake Tools for Visual Studio 2.6.1000.0 Microsoft Azure Data Lake Tools for Visual Studio Azure Functions and Web Jobs Tools 16.10.526.50910 Azure Functions and Web Jobs Tools Azure Stream Analytics Tools for Visual Studio 2.6.1000.0 Microsoft Azure Stream Analytics Tools for Visual Studio C# Tools 3.10.0-4.21318.11+7ceb633154acb9d716fd3eb2b6df1a0468d8e416 C# components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Command1 Extension 1.0 Command1 Visual Studio Extension Detailed Info Common Azure Tools 1.10 Provides common services for use by Azure Mobile Services and Microsoft Azure Tools. Developer News 0.6.64 Always stay up to date with developer news from the Visual Studio team and other sources right within Visual Studio or your default browser. EditorConfig Language Service 1.17.288 Language service for .editorconfig files. EditorConfig helps developers define and maintain consistent coding styles between different editors and IDEs. Extensibility Message Bus 1.2.6 (master@34d6af2) Provides common messaging-based MEF services for loosely coupled Visual Studio extension components communication and integration. Fabric.DiagnosticEvents 1.0 Fabric Diagnostic Events File Icons 2.7 Adds icons for files that are not recognized by Solution Explorer Insert Guid 1.0 Makes it super easy to insert a new GUID into any editor and input field IntelliCode Extension 1.0 IntelliCode Visual Studio Extension Detailed Info Markdown Editor 1.12.253 A full featured Markdown editor with live preview and syntax highlighting. Supports GitHub flavored Markdown. Microsoft Azure HDInsight Azure Node 2.6.1000.0 HDInsight Node under Azure Node Microsoft Azure Hive Query Language Service 2.6.1000.0 Language service for Hive query Microsoft Azure Service Fabric Tools for Visual Studio 16.10 Microsoft Azure Service Fabric Tools for Visual Studio Microsoft Azure Stream Analytics Language Service 2.6.1000.0 Language service for Azure Stream Analytics Microsoft Azure Stream Analytics Node 1.0 Azure Stream Analytics Node under Azure Node Microsoft Azure Tools 2.9 Microsoft Azure Tools for Microsoft Visual Studio 2019 - v2.9.40423.1 Microsoft Continuous Delivery Tools for Visual Studio 0.4 Simplifying the configuration of Azure DevOps pipelines from within the Visual Studio IDE. Microsoft JVM Debugger 1.0 Provides support for connecting the Visual Studio debugger to JDWP compatible Java Virtual Machines Microsoft Library Manager 2.1.113+g422d40002e.RR Install client-side libraries easily to any web project Microsoft MI-Based Debugger 1.0 Provides support for connecting Visual Studio to MI compatible debuggers Microsoft Visual Studio Tools for Containers 1.2 Develop, run, validate your ASP.NET Core applications in the target environment. F5 your application directly into a container with debugging, or CTRL + F5 to edit & refresh your app without having to rebuild the container. Mono Debugging for Visual Studio 16.10.15 (552afdf) Support for debugging Mono processes with Visual Studio. NuGet Package Manager 5.10.0 NuGet Package Manager in Visual Studio. For more information about NuGet, visit https://docs.nuget.org/ ProjectServicesPackage Extension 1.0 ProjectServicesPackage Visual Studio Extension Detailed Info Razor (ASP.NET Core) 16.1.0.2122504+13c05c96ea6bdbe550bd88b0bf6cdddf8cde1725 Provides languages services for ASP.NET Core Razor. Snapshot Debugging Extension 1.0 Snapshot Debugging Visual Studio Extension Detailed Info SQL Server Data Tools 16.0.62106.24090 Microsoft SQL Server Data Tools StylerPackage Extension 1.0 StylerPackage Visual Stuido Extension Detailed Info SVG Viewer 1.0.14 Makes it much easier to work with SVG files by showing a live preview in the bottom-right corner of the code window ToolWindowHostedEditor 1.0 Hosting json editor into a tool window TypeScript Tools 16.0.30429.2002 TypeScript Tools for Microsoft Visual Studio Visual Basic Tools 3.10.0-4.21318.11+7ceb633154acb9d716fd3eb2b6df1a0468d8e416 Visual Basic components used in the IDE. Depending on your project type and settings, a different version of the compiler may be used. Visual F# Tools 16.10.0-beta.21262.7+1b23bbeda88ea3cb9be9af777f4c99fa8663df81 Microsoft Visual F# Tools Visual Studio Code Debug Adapter Host Package 1.0 Interop layer for hosting Visual Studio Code debug adapters in Visual Studio Visual Studio Container Tools Extensions 1.0 View, manage, and diagnose containers within Visual Studio. Visual Studio Tools for Containers 1.0 Visual Studio Tools for Containers Visual Studio Tools for Kubernetes 1.0 Visual Studio Tools for Kubernetes VisualStudio.DeviceLog 1.0 Information about my package VisualStudio.Mac 1.0 Mac Extension for Visual Studio Xamarin 16.10.000.234 (d16-10@ecaf29b) Visual Studio extension to enable development for Xamarin.iOS and Xamarin.Android. Xamarin Designer 16.10.0.115 (remotes/origin/c750fbf1bde3c720d077f51640fe197c6dac7cbe@c750fbf1b) Visual Studio extension to enable Xamarin Designer tools in Visual Studio. Xamarin Templates 16.10.5 (355b57a) Templates for building iOS, Android, and Windows apps with Xamarin and Xamarin.Forms. Xamarin.Android SDK 11.3.0.4 (d16-10/ae14caf) Xamarin.Android Reference Assemblies and MSBuild support. Mono: b4a3858 Java.Interop: xamarin/java.interop/d16-10@f39db25 ProGuard: Guardsquare/proguard/v7.0.1@912d149 SQLite: xamarin/sqlite/3.35.4@85460d3 Xamarin.Android Tools: xamarin/xamarin-android-tools/d16-10@c5732a0 Xamarin.iOS and Xamarin.Mac SDK 14.20.0.24 (c4b89cddb) Xamarin.iOS and Xamarin.Mac Reference Assemblies and MSBuild support. ```

Screenshots

Screenshot

jsuarezruiz commented 2 years ago

Are you trying something like: 

<Picker>
    <VisualStateManager.VisualStateGroups>
        <VisualStateGroup x:Name="CommonStates">
            <VisualState x:Name="Disabled">
                <VisualState.Setters>
                    <Setter Property="TextColor" Value="Gray" />
                </VisualState.Setters>
            </VisualState>
        </VisualStateGroup>
    </VisualStateManager.VisualStateGroups>
</Picker>

or, using Styles?

ahoke-cr commented 2 years ago

@jsuarezruiz yes, that's right. I suppose I could also try with using triggers, but it seems that the platform renderers don't look at the text color property but instead look straight to the platform disabled text color.

ahoke-cr commented 2 years ago

What I'm referring to: https://github.com/xamarin/Xamarin.Forms/blob/5f284f9714da716e4ce6a2cd0bd274dadfb638e8/Xamarin.Forms.Platform.iOS/Renderers/DatePickerRenderer.cs#L237

ahoke-cr commented 1 year ago

Any follow-up? These controls are useless if you want to support dark mode in their current state.