search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.64k stars 1.88k forks source link

Fixing issue #15314 #15687

Closed dennisstromberg closed 3 months ago

dennisstromberg commented 1 year ago

Description of Change

Before updating textdecorations in LabelRenderer, it is necessary to check if it is using FormattedText and if any of its spans are styled with TextDecorations. If this is the case, the process should return to avoid removing the existing styling.

Issues Resolved

API Changes

None

Platforms Affected

Behavioral/Visual Changes

TextDecorations will now show when updating FormattedText after initial render.

Before/After Screenshots

Not applicable

Testing Procedure

Create a label with text and a button that setting the FormattedText in the codebehind.

PR Checklist

jfversluis commented 1 year ago

/azp run

azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
azure-pipelines[bot] commented 1 year ago
Azure Pipelines successfully started running 1 pipeline(s).
jfversluis commented 3 months ago

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!