search

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.
https://aka.ms/xamarin-upgrade
Other
5.63k stars 1.87k forks source link

Remove interfering keyboard focus logic #15873

Closed MichaelRumpler closed 5 months ago

MichaelRumpler commented 6 months ago

Description of Change

This is a backport of https://github.com/dotnet/maui/commit/a3d8d2034377fb169a13ff7e196a482ccfbd4686 which fixed https://github.com/dotnet/maui/issues/5916 in MAUI two years ago. The responding code already existed in Xamarin.Forms before, but the fix was only done in MAUI.

Essentially it removes the code which hid the soft keyboard when you touch anywhere outside an Editor or Entry.

Issues Resolved

API Changes

None

Platforms Affected

Behavioral/Visual Changes

When an Entry is focused, tapping any other element does not close the soft keyboard.

PR Checklist

MichaelRumpler commented 6 months ago

@microsoft-github-policy-service agree

jfversluis commented 5 months ago

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!