Fixed issue #15874 - NRE when iOS app is running on MacOS and "More" item is clicked in ListView context menu

xamarin / Xamarin.Forms

Xamarin.Forms is no longer supported. Migrate your apps to .NET MAUI.

https://aka.ms/xamarin-upgrade

Other

5.64k stars 1.88k forks source link

Fixed issue #15874 - NRE when iOS app is running on MacOS and "More" item is clicked in ListView context menu #15875

Closed VitalyKnyazev closed 2 months ago

VitalyKnyazev commented 3 months ago

Description of Change

Fixed an NRE when iOS app runs in MacOS

Issues Resolved

fixes #15874

API Changes

None

Platforms Affected

Behavioral/Visual Changes

None

Before/After Screenshots

TBD

Testing Procedure

Launch an iOS app with ListView and its context menu on MacOS, click on "More" item in the context menu. Previously the app crashed, now you should see correct popup with "Cancel" button.

PR Checklist

[ ] Targets the correct branch
[ ] Tests are passing (or failures are unrelated)

jfversluis commented 2 months ago

Now that we're so close to the sunsetting of Xamarin.Forms unfortunately we won't be able to take this in anymore, we're really sorry about that. Nevertheless, thank you so much for your time and effort that you have put into this PR.

Please have a look at the evolution of Xamarin.Forms, .NET MAUI. A lot of development has been going on there. Hopefully this issue was already fixed in that codebase. If not, feel free to port this over to there.

Again, thank you so much for being a contributor and Xamarin.Forms user!