search

xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.
Other
215 stars 104 forks source link

Bugfix: Make scroll indicators visible in iOS17 #1056

Closed wutschel closed 3 weeks ago

wutschel commented 1 month ago

Description

Closes https://github.com/xbmc/Official-Kodi-Remote-iOS/issues/1007.

As discussed in https://github.com/xbmc/Official-Kodi-Remote-iOS/pull/1044 a workaround was found to make the scroll indicator visible again for several views. This PR introduces this workaround for the main library view only. Other view do not seem to be impacted by this problem.

Summary for release notes

Bugfix: Make scroll indicators visible in iOS17

wutschel commented 1 month ago

This is crazy. The same workaround in DetailViewController does not work when an instance is used in UIModalPresentationFullScreen -- like done in settings.

wutschel commented 1 month ago

I need to correct myself. The problem does not happen on UIModalPresentationFullScreen, but when entering another instance of DetailViewController = browsing through the library or settings.

Example:

  1. Enter movie genres -> indicator visible
  2. Enter a movie gerne and show list of movies -> indicator invisible.
wutschel commented 1 month ago

When adding a delay the use case mentioned above works. 0.1 seconds is not enough, 0.5 seconds works quite well so far. Any idea where I could better hook this up? Is there any framework call which comes after viewDidAppear?

wutschel commented 1 month ago

@kambala-decapitator, the timeout gave the final hint. Obviously there are still layout related commands called inside DetailViewController's viewDidAppear. The processing finally ends with calling displayData. If I just again set the visibility of the scroll indicator there, the issue is gone -- without a timeout.

kambala-decapitator commented 3 weeks ago

FYI tried adding setting content offset + scroll to index path to viewDidAppear in a test app - still couldn't reproduce...