xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.
Other
215 stars 104 forks source link

Bugfix: iPad stack view did not mask bounds #1060

Closed wutschel closed 3 weeks ago

wutschel commented 1 month ago

Description

Fixes a regression of https://github.com/xbmc/Official-Kodi-Remote-iOS/pull/1043 which was reported in this forum post.

The PR re-introduces the UIView maskView to DetailViewController which is required to be able to set clipsToBounds to hide the inactive elements (e.g. more items menu or grid view) out of sight on iPad. Directly setting a mask for self.view is not possible as this would not allow to add visible shadows (see addShadowsToView) around the masked area.

Summary for release notes

Bugfix: iPad stack view did not mask bounds

wutschel commented 1 month ago

If there is any better solution I am all ears.