search

xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.
Other
215 stars 104 forks source link

Improvement: IPv4, IPv6 and host name can be changed after calling Find Kodi once #1069

Closed wutschel closed 3 weeks ago

wutschel commented 1 month ago

Description

Suggested by @kambala-decapitator.

"Find Kodi" now only needs to be called once. This is will execute the service discovery for all supported address types. Afterwards the user can select the address type without running "Find Kodi" again.

Important: MAC address can only be resolved using iPv4. The code has been changed to use only IPv4 for this, even if the user selects IPv6 or host name as address type. If IPv4 address cannot be found, the MAC address cannot be resolved.

Summary for release notes

Improvement: IPv4, IPv6 and host name can be selected after calling Find Kodi once

wutschel commented 1 month ago

@kambala-decapitator, I am making this draft as it would be good, if you can test this. I don't want to mess this up right before the release.

wutschel commented 3 weeks ago

you may also want to fix typos in the first commit message

Thanks, fixed this as well.

wutschel commented 3 weeks ago

Reworked, squashed and rebased to master.