Improvement: Global Search support for cast, plot and tagline

xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.

Other

219 stars 104 forks source link

Improvement: Global Search support for cast, plot and tagline #1083

Closed wutschel closed 1 month ago

wutschel commented 3 months ago

Description

This PR implements support to search for cast, plot and tagline in Global Search. For cast both actors and roles can be searched.

cast is supported for Movies and TV Shows,
plot is supported for Movies and Videos
tagline is supported for Movies

Summary for release notes

Improvement: Global Search support for cast, plot and tagline

wutschel commented 1 month ago

This now caused an undesired regression (major increase of sync time). With my small test database I was recognizing this. Can the PR still be reverted? Or do I need to create a new PR for this?

wutschel commented 1 month ago

This now caused an undesired regression (major increase of sync time). With my small test database I was recognizing this. Can the PR still be reverted? Or do I need to create a new PR for this?

Edit: There is small improvement in there which I would to not revert. It was removing an unused variable in DetailViewController. So maybe better to just create a new PR rolling back the changes and add statement on the resolved regression in the "Summary for release notes" section?

kambala-decapitator commented 1 month ago

I can revert the whole PR and then create another one by cherry-picking the small improvement commit

wutschel commented 1 month ago

I can revert the whole PR and then create another one by cherry-picking the small improvement commit

Great, let's do.