wutschel
commented
2 months ago Thanks for feedback and the suggestion. From a UI perspective I can imagine to go for a 2nd press of the gerne toolbar icon to toggle between genre and tag view. Similar functions are implemented for the movies toolbar icon which toggles through all > unwatched > watched movies. But sadly this cannot be implemented straight forward as this is not in line with how the app logic is organized. It would be easy to add "tag" when synchronizing movies (increasing also the sync time) and allow searching for "tag" in Global Search. This is only a few lines of code. Alternatively I can imagine to create a new submenu, like for genres, selectable after entering "...". But this more complicated as the API does have a "GetTags" method and the whole processing must be implemented only for this very functionality.
gavinstevenson
First off, great app. Of all the iOS-compatible Kodi remotes, I think this one is the best.
Feature Request
Jumping right into the feature request, would you be open to adding a "Tag" view to the app?
In the "Movies" main menu item, there are several icons on the bottom right that change the right panel's view when pressed. These are "Movies", "Genres", "Movie Sets" and "Recently Added" followed by a "..." for all other views.
While the "Genres" view is useful when the user just wants to watch any action or comedy movie, it lacks granularity. What if the user wants to watch a mafia movie? A WWII movie? A movie about the sea? Genres aren't this specific, but the tags on IMDB and TMDB can get extremely precise and when they're scraped into a user's library, they offer an extremely useful way to quickly find the perfect film for movie night.
Implementation Details
As I understand it, the way the app currently gets library info from Kodi is by issuing the following JSON query:
[root@basementhtp ~]$ curl --data-binary '{"jsonrpc":"2.0","method":"VideoLibrary.GetMovieDetails","params":{"movieid":3,"properties":["year","playcount","rating","thumbnail","genre","runtime","studio","director","plot","mpaa","votes","cast","file","fanart","resume","trailer","dateadded","tagline","art"]},"id":2}' -H 'content-type: application/json;' http://basementhtpc:8080/jsonrpc | python3 -m json.toolIf "tag" was added as an additional property to the above query list, Kodi will dutifully supply all the tags associated with the relevant movieid.
But then where should we expose those tags in the UI of the App? I can see two natural locations: the first would be on each movie's info pane. Right under the "genres" section would work, but since tags are often more numerous/plentiful than genres (it's not uncommon for movies to have 3-6 tags while only 1-2 genres), I could also understand wanting to put them closer to the bottom, right after the rating for design/layout reasons. Please see here for a screenshot.
But knowing what specific tags a movie has is only half the battle. How do we help a user quickly scroll through all the tags in their library in much the same way they can scroll through all the genres in their library?
A Tag view, implemented in exactly the same way we have a Genre view, would be very useful. Please see here for a screenshot.
Useful Resources
In the spirit of trying to be as helpful as possible, here are some additional links/resources that you might find useful:
Here's a properly formatted/compliant .NFO of the same movie from TMDB containing "tag" tags (they're enumerated near the top, right under the "genre" tags):
Here's what a successful result looks like when querying Kodi via the JSON API for the above .NFO. Note the tags returned as a set of strings in the middle of the excerpt below: