search

xbmc / Official-Kodi-Remote-iOS

Full-featured remote control for XBMC Media Center. It features library browsing, now playing informations and a direct remote control.
Other
217 stars 104 forks source link

Maintenance: Plurals should be implemented using stringsdict #479

Open wutschel opened 2 years ago

wutschel commented 2 years ago

During reviewing https://github.com/xbmc/Official-Kodi-Remote-iOS/pull/476 it was mentioned that the way how plurals are treated should be changed to stringsdict.

Example: NSString *minutesUnit = minutes > 1 ? LOCALIZED_STR(@"Mins.") : LOCALIZED_STR(@"Min");

Strings using this kind of solution:

"1 result" = "1 Ergebnis";
"%d results" = "%d Ergebnisse";
"Songs" = "Lieder";
"Song" = "Lied";
"Mins." = "Min.";
"Min" = "Min";
"vote" = "Bewertung";
"votes" = "Bewertungen";
"Not listened" = "Nicht gehört";
"Listened one time" = "Einmal gehört";
"Listened %@ times" = "%@ mal gehört";
"Not watched" = "Nicht gesehen";
"Watched one time" = "Einmal gesehen";
"Watched %@ times" = "%@ mal gesehen";
wutschel commented 1 year ago

@kambala-decapitator, I am wondering, if the work to make this functioning with Weblate is not too much of effort compared to the benefit. Not too much "bang for the buck".

kambala-decapitator commented 1 year ago

not a high priority, can be done later. But having proper localisation Is desired I'd say.