xcp-ng / xcp

Entry point for issues and wiki. Also contains some scripts and sources.
https://xcp-ng.org
1.25k stars 74 forks source link

Smartmontools 7 #309

Open gdelafond opened 4 years ago

gdelafond commented 4 years ago

Hello,

It would be nice to have by default Smartmontools 7 and not 6.5 (which more than 3 years old) ;-) It is available in the CentOS base repo.

Thank you.

stormi commented 4 years ago

Changing the default version requires testing to avoid regressions. We'd need to track down where exactly smartmontools is used to make sure there's no risk of regressions.

Is version 7 100% backward compatible with version 6.5? If not, what changed?

gdelafond commented 4 years ago

@stormi I don't really know what has changed between the two version. I know that many disks type have been added in the database included in version 7. I think it is not 100% backward compatible because of that : - smartctl '-x': Now includes '-l defects'.. Other changes seems to be only added options.

Does CH/XCP-NG use smatmontools ?

The changelog is here : https://www.smartmontools.org/browser/tags/RELEASE_7_0/smartmontools/NEWS

For information, the disk database is in the .h file : https://sourceforge.net/p/smartmontools/code/HEAD/tree/trunk/smartmontools/drivedb.h

gdelafond commented 4 years ago

Oh, I just found that the database could be updated separatly. https://www.smartmontools.org/wiki/Download#Updatethedrivedatabase

gdelafond commented 4 years ago

I will test it as soon as I can.

stormi commented 4 years ago

Was the database update test successful, without requiring an update of the software itself?

hoerup commented 3 years ago

I think the json output in smartmontools 7 will make it easier to implement #263

gdelafond commented 3 years ago

Sorry I forgot to answer here. I just replaced drivedb.h by a new one and it worked (on XCP-NG 8.2).

curl -o ~/drivedb.h https://www.smartmontools.org/browser/branches/RELEASE_7_2_DRIVEDB/smartmontools/drivedb.h?format=txt
cp /usr/share/smartmontools/drivedb.h /usr/share/smartmontools/drivedb.h.sav
cp ~/drivedb.h /usr/share/smartmontools/drivedb.h