xcp-ng / xcp

Entry point for issues and wiki. Also contains some scripts and sources.
https://xcp-ng.org
1.31k stars 74 forks source link

place for XCP-ng Center to host update.xml #36

Open borzel opened 6 years ago

borzel commented 6 years ago

@olivierlambert can you please

Background: I dont want to implement the updatesystem for XCP-ng Center (permanently) based on github. For privacy and other reasons.

stormi commented 6 years ago

Hi! Do you still need such a place? I think we could upload files to a subdirectory of https://updates.xcp-ng.org/ if @olivierlambert agrees, or somewhere else.

olivierlambert commented 6 years ago

Because our update system is vastly different than Citrix, I don't see that's still relevant. XCP-ng Center should rely on our XAPI update plugin.

stormi commented 6 years ago

I thought that was for updating XCP-ng Center, not XCP-ng itself.

borzel commented 6 years ago

yes, the need is present. it's for updating XCP-ng Center itself.

@olivierlambert how should this work? Update XCP-ng per yum and then download the new update from the xcp-ng host? the current update system just needs a xml-file (https://github.com/xcp-ng/xenadmin/blob/master/updates.xml) and a place to download the released software.

olivierlambert commented 6 years ago

Oh okay I thought it was for updating XCP-ng hosts. Why not having directly checking the XML on GitHub? This would be easier for you :)

borzel commented 6 years ago

read in my initial text:

Background: I dont want to implement the updatesystem for XCP-ng Center (permanently) based on github. For privacy and other reasons.

olivierlambert commented 6 years ago

I'm not sure to understand? It's just a XML with numbers right? I probably don't get it, can you develop? The great thing about getting it on GitHub is there is no need to synchronize anything else than merging/pushing to modify the file and that's it.

I mean I'm not against hosting it on xcp-ng.org, but this will require extra work to have something sync with this repo anyway.

borzel commented 6 years ago

Of course its easier. Currently that's the way it works. Not a big problem at all.

The only downside is that github can now "see" how many connections are made to that xml file. Every XCP-ng Center Host that checks for update connects to this file on a regular basis. Users can turn this check off, but I thought we can provide an alternative to it, so that Github is not collecting metadata from our updatingsystem.

I could also host this file on my own webserver, but an update url with xcp-ng.org in it would be better :-)

There is no need to have this file in Github.

olivierlambert commented 6 years ago

No, update requests for XCP-ng Center are only coming from your XCP-ng Center client. Not the host. So it's only coming from your current Windows OS where you installed the client.

XCP-ng updates rely on the repository file content inside /etc/yum.repos.d/xcp-ng.repo, which today target updates.xcp-ng.org domain.

borzel commented 6 years ago

your are right, I meant XCP-ng Center Host... not the Server itself... was a typo ✍️

borzel commented 6 years ago

To sum up what was my goal: to geht a place where I can "upload" the xml file for updating purposes to keep the url's used in this project to one main domain and not relying on github for that.

Reasons:

I understand that it is the easy way to keep the file on Github (because of that I do this currently).

I just wanted to have this discussed/overthought/guided. Maybe there is another option? Turn off the updating thing completely in XCP-ng Center? Create a subdomain like center.xcp-ng.org which I can controll/fill with data on my own?

olivierlambert commented 6 years ago

I can try to have a CRON-like script that fetch the files from GitHub every day so when a new version is available, it will be automatically copied on XCP-ng URL.

edit: I understand now your privacy question, sorry it wasn't clear for me in the first place

borzel commented 6 years ago

cron would be fine :-)

good that we are able to clear our communication problems with the help of normal human interaction ;-)

olivierlambert commented 6 years ago

Haha yes, we are totally humans behind screen, typing with our human hands

P.S: we are totally not :robot:

borzel commented 6 years ago

Rrrrrrobotttt ;-)