search

xcp-ng / xcp

Entry point for issues and wiki. Also contains some scripts and sources.
https://xcp-ng.org
1.32k stars 74 forks source link

LVM: set archive=1 in /etc/lvm/lvm.conf #619

Open DSJ2 opened 1 year ago

DSJ2 commented 1 year ago

From /etc/lvm/lvm.conf:

backup {
        # Configuration option backup/archive.
        # Maintain an archive of old metadata configurations.
        # Think very hard before turning this off. 
        archive = 0

think very hard before turning this off Why is archive off in xcp-ng?

stormi commented 1 year ago

This comes from XenServer's packaging of lvm. It's explicitly disabled with: 

sed -i 's/archive = .*/archive = 0/' $RPM_BUILD_ROOT/%{_sysconfdir}/lvm/lvm.conf

So there is a reason, but I don't see any comments or changelog entries which explains why, and there is no public repository whose history we could look at.

There is no XenServer public bugtracker for these package sources, but you may try to reach the main people involved in this decision on the repository for Storage Manager: https://github.com/xapi-project/sm/issues

stormi commented 1 year ago

Also CCing @Wescoeur in case he knows something I don't.

Wescoeur commented 1 year ago

I don't know what the real reason for this change is, but it may prevent rollback to a specific position to ensure there is no problem on the sm side (e.g. LVHDSR).

DSJ2 commented 1 year ago

Opened https://github.com/xapi-project/sm/issues/635

MarkSymsCtx commented 2 days ago

It's actually disabled by Redhat in the upstream packaging, XenServer (and then xcp-ng as a downstream of XenServer) just inherits that setting. If xcp-ng want to apply a different value they are more than welcome to rebuild the package to their own requirements.