search

xenserver / xscontainer

Support for Docker and Container Management
BSD 2-Clause "Simplified" License
25 stars 14 forks source link

add parser for bandi scanner #53

Closed TalonsLee closed 5 years ago

TalonsLee commented 5 years ago

Signed-off-by: Xin Li talons.lee@gmail.com

liulinC commented 5 years ago

The PR looks good, the commit add a parser to read the bandit Scaner result which is a json file and format the output.

The question about this PR is, is there any plain to integrate the bandit scanner into this repo, or it has already been integreted.

TalonsLee commented 5 years ago

The PR looks good, the commit add a parser to read the bandit Scaner result which is a json file and format the output.

The question about this PR is, is there any plain to integrate the bandit scanner into this repo, or it has already been integreted.

Bandit will not be integrate to this repo. Bandit lastest docker image will be used in jenkins "security scan" stage,

TalonsLee commented 5 years ago

this is a big change, can you add one readme to describing how to use this scanner? and its testing results etc. how is this one will help? Also looks the travis is failed.

This failure is not related to this commit.

liulinC commented 5 years ago

Merge this commit as it is a good enhancement and has no impact to the original code.

Zhengchai commented 5 years ago

do you have test result please? or a readme about how to use this tool?

liulinC commented 5 years ago

@TalonsLee Please intergrate the bandit scan into the Jenkins as well.