Closed xinyue-ash closed 1 month ago
Tested on multiple target with angle + duration config, if several targets in one sequence, then servo will not stop after (faster) intended duration.
Issue: due to the rounding when calculate speed ( duration / angle) , also the rounding of ellipse time check, as million returns unsign long.
Solution: ~~1. using a fix point arithmetic (AKA store speed as speed * 1000 to preserve the precision)
that PR is cancel due to the bug
Tested on multiple target with angle + duration config, if several targets in one sequence, then servo will not stop after (faster) intended duration.
Issue: due to the rounding when calculate speed ( duration / angle) , also the rounding of ellipse time check, as million returns unsign long.
Solution: ~~1. using a fix point arithmetic (AKA store speed as speed * 1000 to preserve the precision)