xiph / opus

Modern audio compression for the internet.
https://opus-codec.org/
Other
2.31k stars 619 forks source link

Is NE10 still useful? #63

Open Brahmasmi opened 7 years ago

Brahmasmi commented 7 years ago

I am layman user of the codec. I chanced upon the NE10 switch while trawling the source code to find ways through which I could help improve the audio output performance of ExoPlayer since I was getting audible glitches. This was quite some time back. Meanwhile, it seems that the good folks at Google have added some NEON related things to opus (pardonne moi for my complete ignorance).

I have no idea whether NE10 has any utility any more, and whether removing it would have any impact. Furthermore, is there a need/mechanism to activate the NEON related things added to the codec or are they automatically activated?

Apologies for the dumb queries.

@mjbshaw @jmvalin

mjbshaw commented 7 years ago

In my profiling, I found NE10 to decrease decoding/encoding times by 1-3% (approximately). I don't think I can say whether that decrease is considered appreciable or negligible; I think the answer to that may be context dependent.