fix(android popup instantiation): enable design customization

Alexander-Bliznyuk commented 5 years ago

PR Checklist

[x ] The PR title follows our guidelines: https://github.com/NativeScript/NativeScript/blob/master/CONTRIBUTING.md#commit-messages.
[ x] There is an issue for the bug/feature this PR is for. To avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it.
[ ] All existing tests are passing
[ ] Tests for the changes are included

What is the current behavior?

It's impossible to apply android styles to popup. There was a request (#1) to implement mechanism to change default look. Although such an implementation is impossible or really challenging due to popups' nature, Android provides means to style them. Here's a simple example:

res/values/styles.xml

    <style name="AppTheme" parent="AppThemeBase">       
        <item name="android:popupMenuStyle">@style/PopupMenu</item>      
    </style>    
    <style name="PopupMenu" parent="@android:style/Widget.PopupMenu">    
        <item name="android:popupBackground">#fbae17</item>    
    </style>

An Activity(instead of Application) class should be passed to PopupMenu constructor in order to apply this style.

What is the new behavior?

Popup styles take effect.

Fixes/Implements/Closes #1 .

xlmnxp commented 5 years ago

thank you, I will not close issue because I want support customize iOS

xlmnxp commented 5 years ago

thank you again

xlmnxp commented 5 years ago

📦 nativescript-menu@1.1.3 merged

xlmnxp / nativescript-menu