removed the dummy infura id from the app code

xmtp / example-chat-react

This repo has been archived. Replacement apps include the XMTP Quickstart React and XMTP Inbox chat apps. For more details and links, see the README in this repo.

MIT License

74 stars 52 forks source link

removed the dummy infura id from the app code #174

Closed bhavya2611 closed 1 year ago

bhavya2611 commented 1 year ago

Removes the dummy infura id in code and hence we will always need to give one in env file

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
dev-dot-xmtp-dot-chat	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Jan 20, 2023 at 5:10PM (UTC)

cloudflare-workers-and-pages[bot] commented 1 year ago

Deploying with Cloudflare Pages

Latest commit:	`7d67e9e`
Status:	✅ Deploy successful!
Preview URL:	https://8d597116.chat-3hb.pages.dev
Branch Preview URL:	https://fix-infura-issue.chat-3hb.pages.dev

View logs

bhavya2611 commented 1 year ago

@elisealix22 not really right, rather people need to have that in their .env file, also should it be .env and not .env.local, because I don't think people will be using local network, or that would be very rare

elisealix22 commented 1 year ago

I think there's already language in the README for setting up the env variable 👀. It's just the preconfigured line we want to strip out since we are removing that with this change