search

xnuinside / simple-ddl-parser

Simple DDL Parser to parse SQL (HQL, TSQL, AWS Redshift, BigQuery, Snowflake and other dialects) ddl files to json/python dict with full information about columns: types, defaults, primary keys, etc. & table properties, types, domains, etc.
MIT License
179 stars 40 forks source link

In the Bigquery apostrophes to delimiter decription string not work #177

Closed lmarqueto closed 1 year ago

lmarqueto commented 1 year ago

Describe the bug In the Bigquery when we use apostrophes to delimiter description string in options make parse fail

To Reproduce This fail CREATE TABLE data.test ( col STRING OPTIONS(description='test') ) OPTIONS(description='test'); and this work

CREATE TABLE data.test ( col STRING OPTIONS(description="test") ) OPTIONS(description="test");

Expected behavior Both statements should parsed

xnuinside commented 1 year ago

@lmarqueto thanks for reporting the issue! I already have released fix in version 0.29.1 and added the test https://github.com/xnuinside/simple-ddl-parser/pull/179/files#diff-ff905774288e5cd43c5adcde46191c8990ae3fc1472fe5315344493aa946aade

xnuinside commented 1 year ago

I will close the issue, if needed something more - feel free to open the new one!

lmarqueto commented 1 year ago

@xnuinside Thank you very much for your attention and for the super fast resolution 🚀