search

xnuinside / simple-ddl-parser

Simple DDL Parser to parse SQL (HQL, TSQL, AWS Redshift, BigQuery, Snowflake and other dialects) ddl files to json/python dict with full information about columns: types, defaults, primary keys, etc. & table properties, types, domains, etc.
MIT License
179 stars 40 forks source link

feature #218 solve my requirement #220

Closed dmaresma closed 8 months ago

dmaresma commented 8 months ago

Hi and Happy New Year ! I would like summit to you my contribution to solve the EXTERNAL TABLE and Virtual Column ddl.

Thanks again to initiate and support this project.

218 issue solver

xnuinside commented 8 months ago

@dmaresma hello again :) and happy new year you too! Thanks for submitting the PR. I see flake 8 issues. In repo there is the pre-commit hooks, you can run ‘pre-commit install’ and ‘pre commit run -- all-files’ to check those issues on local machine

xnuinside commented 8 months ago

You solved it faster than I added my comment :)

dmaresma commented 8 months ago

My Bad, I introduce regression, by not running all test before, I'm back on the workbench.

dmaresma commented 8 months ago

@xnuinside Ta da, it's fixed all tests passed, thanks for your time.

xnuinside commented 8 months ago

@dmaresma awesome, thank you! I will release it soon

xnuinside commented 8 months ago

@dmaresma released in version 0.31.3 https://pypi.org/project/simple-ddl-parser/