search

xnuinside / simple-ddl-parser

Simple DDL Parser to parse SQL (HQL, TSQL, AWS Redshift, BigQuery, Snowflake and other dialects) ddl files to json/python dict with full information about columns: types, defaults, primary keys, etc. & table properties, types, domains, etc.
MIT License
175 stars 40 forks source link

Support Parse MYSQL DDL with 'COLLATE' option & fix class typo #266

Closed bomwo closed 2 days ago

bomwo commented 3 weeks ago

Hello,

This Pull Request addresses the following two issues: Fix Issue #265:

Problem Description: This resolves the bug reported in Issue #265. Solution: Identified the cause of the bug and corrected the relevant code. This ensures the affected functionality works as intended. Correct Class Name Typo:

Problem Description: A typo was found in a specific class name within the codebase. Solution: Corrected the typo to improve code readability and maintain consistency. I hope this contribution helps improve the quality of the project. I would appreciate it if you could review the changes.

Please let me know if there are any further adjustments or feedback needed.

Thank you.

xnuinside commented 2 days ago

@bomwo thanks for the PR and sorry for the delay! I will create new release today

xnuinside commented 2 days ago

@bomwo https://pypi.org/project/simple-ddl-parser/ I just released 1.5.2 version with your changes

bomwo commented 1 day ago

@bomwo https://pypi.org/project/simple-ddl-parser/ 방금 귀하의 변경 사항을 적용하여 1.5.2 버전을 출시했습니다.

Thank you for your review. :+1: