Adding single quotes around Object, ArrayRef and HashRef barewords

[clalansingh]

Hi there,

I've discovered that two tests have been failing which can be solved by adding single quotes to barewords. The failed tests are:

t/020_attributes/014_misc_attribute_coerce_lazy.t .............. Bareword found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 31, near "coerce"
        (Missing semicolon on previous line?)
Bareword found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 37, near "has"
        (Missing semicolon on previous line?)
String found where operator expected at t/020_attributes/014_misc_attribute_coerce_lazy.t line 37, near "has 'headers'"
        (Do you need to predeclare has?)
"my" variable $r masks earlier declaration in same statement at t/020_attributes/014_misc_attribute_coerce_lazy.t line 47.
syntax error at t/020_attributes/014_misc_attribute_coerce_lazy.t line 31, near "coerce "
Execution of t/020_attributes/014_misc_attribute_coerce_lazy.t aborted due to compilation errors.
t/020_attributes/014_misc_attribute_coerce_lazy.t .............. Dubious, test returned 255 (wstat 65280, 0xff00)
No subtests run 

t/040_type_constraints/005_util_type_coercion.t ................ 1/8 Semicolon seems to be missing at t/040_type_constraints/005_util_type_coercion.t line 27.
syntax error at t/040_type_constraints/005_util_type_coercion.t line 28, near "coerce "
Execution of t/040_type_constraints/005_util_type_coercion.t aborted due to compilation errors.
# Looks like your test exited with 255 just after 1.
t/040_type_constraints/005_util_type_coercion.t ................ Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 7/8 subtests 

With the summary as follows:

Test Summary Report
-------------------
t/020_attributes/014_misc_attribute_coerce_lazy.t            (Wstat: 65280 Tests: 0 Failed: 0)
  Non-zero exit status: 255
  Parse errors: No plan found in TAP output
t/040_type_constraints/005_util_type_coercion.t              (Wstat: 65280 Tests: 1 Failed: 0)
  Non-zero exit status: 255
  Parse errors: Bad plan.  You planned 8 tests but ran 1.
t/040_type_constraints/018_custom_parameterized_types.t      (Wstat: 0 Tests: 28 Failed: 0)
  TODO passed:   13, 19-20, 22
Files=301, Tests=6105, 53 wallclock secs ( 1.45 usr  0.54 sys + 21.48 cusr  5.17 csys = 28.64 CPU)
Result: FAIL

After fixing the barewords in my pull request, all tests pass:

Test Summary Report
-------------------
t/040_type_constraints/018_custom_parameterized_types.t      (Wstat: 0 Tests: 28 Failed: 0)
  TODO passed:   13, 19-20, 22
t/040_type_constraints/021_maybe_type_constraint.t           (Wstat: 0 Tests: 36 Failed: 0)
  TODO passed:   27
Files=301, Tests=6114, 46 wallclock secs ( 1.71 usr  0.41 sys + 24.36 cusr  5.30 csys = 31.78 CPU)
Result: PASS

Thanks, Chris

[syohex]

Looks good. However I cannot reproduce this issue. Which perl version did you use ?

[clalansingh]

This was on Perl 5.18.2 on Debian 8.

On 10:38PM, Fri, Dec 23, 2016 Syohei YOSHIDA notifications@github.com wrote:

Looks good. However I cannot reproduce this issue. Which perl version did you use ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gfx/p5-Mouse/pull/68#issuecomment-269067236, or mute the thread https://github.com/notifications/unsubscribe-auth/AAk8LviFy2WB5HmkkeGxhT4FndESGprkks5rLJPDgaJpZM4LU8kU .

[syohex]

Thanks for information. I confirmed this bug is reproduced.

[clalansingh]

Great, thanks very much.

On 12:27AM, Sun, Dec 25, 2016 Syohei YOSHIDA notifications@github.com wrote:

Thanks for information. I confirmed this bug is reproduced.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gfx/p5-Mouse/pull/68#issuecomment-269110805, or mute the thread https://github.com/notifications/unsubscribe-auth/AAk8Lm480XIybFYMUs5rnqUdR9sSXZZvks5rLf7KgaJpZM4LU8kU .

[clalansingh]

Hi again,

I was wondering about when changes in the github repo are pushed to CPAN, as the current tag was created in August of 2015. Thanks!

On Sun, Dec 25, 2016 at 8:14 AM, Christopher Lalansingh < clalansingh@gmail.com> wrote:

Great, thanks very much.

On 12:27AM, Sun, Dec 25, 2016 Syohei YOSHIDA notifications@github.com wrote:

Thanks for information. I confirmed this bug is reproduced.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/gfx/p5-Mouse/pull/68#issuecomment-269110805, or mute the thread https://github.com/notifications/unsubscribe-auth/AAk8Lm480XIybFYMUs5rnqUdR9sSXZZvks5rLf7KgaJpZM4LU8kU .

[syohex]

Released