xslate / p5-Mouse

Lightweight class builder for Perl, as a subset of Moose
https://metacpan.org/release/Mouse
Other
46 stars 32 forks source link

fix to build on Perl 5.19.4+ #8

Closed zakame closed 10 years ago

zakame commented 10 years ago

I don't know if you're still looking at your rt.cpan.org queue, but there's a bug posted there that has a patch to enable Mouse building on Perls 5.19.4 and later: https://rt.cpan.org/Public/Bug/Display.html?id=88295 . It has been there for quite some time already, even before YAPC::Asia...

As an aside, you might want to update the Mouse dist's META to point to Github issues as your main bugtracker for Mouse (as that seems to be case already.)

zakame commented 10 years ago

Tested the patch from the RT ticket on my perl 5.19.4 plenv, seems to work and even pass TODO tests:

ironhide% make test
PERL_DL_NONLAZY=1 /home/zakame/.plenv/versions/5.19.4/bin/perl5.19.4 "-MExtUtils::
Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch'); " t/*.t t/*/*.
t
t/000-load.t ................................................... 1/2 # Testing Mou
se/1.12 (XS)
# Soft dependency versions:
#     Class::MOP: 
#     Moose: 
t/000-load.t ................................................... ok   
[...]
All tests successful.

Test Summary Report
-------------------
t/040_type_constraints/018_custom_parameterized_types.t      (Wstat: 0 Tests: 28 Failed: 0)
  TODO passed:   13, 19-20, 22
Files=290, Tests=6030, 21 wallclock secs ( 1.51 usr  0.45 sys + 16.77 cusr  2.52 csys = 21.25 CPU)
Result: PASS
tokuhirom commented 10 years ago

@gfx Is there a reason to reject the patch?

tokuhirom

On Wed, Oct 9, 2013 at 6:29 PM, Zak B. Elep notifications@github.comwrote:

Tested the patch from the RT ticket on my perl 5.19.4 plenv, seems to work and even pass TODO tests:

ironhide% make test PERL_DL_NONLAZY=1 /home/zakame/.plenv/versions/5.19.4/bin/perl5.19.4 "-MExtUtils:: Command::MM" "-e" "testharness(0, 'inc', 'blib/lib', 'blib/arch'); " t/.t t/_/*. t t/000-load.t ................................................... 1/2 # Testing Mou se/1.12 (XS)

Soft dependency versions:

Class::MOP:

Moose:

t/000-load.t ................................................... ok [...] All tests successful.

Test Summary Report

t/040_type_constraints/018_custom_parameterized_types.t (Wstat: 0 Tests: 28 Failed: 0) TODO passed: 13, 19-20, 22 Files=290, Tests=6030, 21 wallclock secs ( 1.51 usr 0.45 sys + 16.77 cusr 2.52 csys = 21.25 CPU) Result: PASS

— Reply to this email directly or view it on GitHubhttps://github.com/gfx/p5-Mouse/issues/8#issuecomment-25957669 .

gfx commented 10 years ago

The reason why I didn't apply the patch was: it wasn't a pull-request.

Now it has been resolved and I've released a new version!