Fix for threads and XS - Githubissues

xslate / p5-Mouse

Lightweight class builder for Perl, as a subset of Moose

https://metacpan.org/release/Mouse

Other

46 stars 32 forks source link

Fix for threads and XS #92

Closed sergeykolychev closed 5 years ago

sergeykolychev commented 5 years ago

@skaji @gfx Looks like threading and scalars made by *_share do not mix well. This deprecates my earlier PR https://github.com/gfx/p5-Mouse/pull/91 because it's much cleaner fix. I use Mouse extensively in my module https://metacpan.org/pod/AI::MXNet and all tests passed while using Mouse with change.

skaji commented 5 years ago

@sergeykolychev Thanks! I merge this PR.

cf: gfx explains newSVpvn_share in his blog post in japanese http://d.hatena.ne.jp/gfx/20090508/1241756870