fix undefined PERL_UNUSED_RESULT symbol on old perl/Devel::PPPort

xslate / p5-Mouse

Lightweight class builder for Perl, as a subset of Moose

https://metacpan.org/release/Mouse

Other

46 stars 32 forks source link

Closed potatogim closed 5 years ago

potatogim commented 5 years ago

Hi.

I'm using perl 5.16 with Mouse on old perl (v5.16.3).

When I try to build latest Mouse, I encountered this error messages.

... undefined symbol: PERL_UNUSED_RESULT ...

So I added conditional macro for this symbol and then It working now gracefully.

skaji commented 5 years ago

@potatogim Thanks. Which version of Devel::PPPort do you use?

I couldn't reproduce this with

skaji commented 5 years ago

According to https://metacpan.org/source/ATOOMIC/Devel-PPPort-3.44/Changes#L54, PERL_UNUSED_RESULT were added in Devel-PPPort 3.33 while Mouse requires Devel-PPPort 3.42+ at configure phase. https://github.com/gfx/p5-Mouse/blob/master/META.json#L30

potatogim commented 5 years ago

@skaji

Yes. We can build latest Mouse from Devel-PPPort 3.33.

I tried to build it on our customized distro which based on CentOS 7 without Devel-PPPort upgrading :) (and I'm using Devel-PPPort 3.20)

I thought we can provide compatibility for this version but as far as you said, It is a requirement for latest version of Mouse.

I'm sorry to have wasted your time.

skaji commented 5 years ago

OK, please upgrade Devel::PPPort first.