search

xtk / X

The X Toolkit
http://www.goXTK.com
Other
795 stars 266 forks source link

Enable tagging #155

Closed RobinNagpal closed 10 years ago

NicolasRannou commented 10 years ago

Please use the built-in setter getter mechanism rather than defining the get methods yourself. See https://github.com/xtk/X/blob/master/objects/volume.js#L563-573 for an example.

RobinNagpal commented 10 years ago

Can some one please merge this pull request. I have incorporated the comments from Nicolas

NicolasRannou commented 10 years ago

Thanks Robin