search

xuchunyang / osx-dictionary.el

Mac OS X Dictionary.app interface for Emacs
139 stars 23 forks source link

string-replace is void, maybe replace-regexp-in-string ? #25

Closed jiacai2050 closed 3 years ago

jiacai2050 commented 3 years ago 
Debugger entered--Lisp error: (void-function string-replace)
  string-replace("·" "" #("point" 0 5 (fontified t)))
  osx-dictionary--get-current-word()
  osx-dictionary-open-dictionary\.app()
  funcall-interactively(osx-dictionary-open-dictionary\.app)
  call-interactively(osx-dictionary-open-dictionary\.app nil nil)
  command-execute(osx-dictionary-open-dictionary\.app)
xuchunyang commented 3 years ago

Oops, I didn't review the last pull request carefully, there is no such function, such issue can be discovered in CI test if the project has one, I will fix it within today.

jiacai2050 commented 3 years ago

Thanks.

After upgrade to 20210308.632, it seems that osx-dictionary-search-word-at-point is aliased, and not autoloaded, this is a breaking change for me, perhaps auto load this alias?

On Mon, Mar 08, 2021 at 09:59:02 AM +0800, Xu Chunyang wrote:

Oops, I didn't review the last pull request carefully, there is no such function, such issue can be discovered in CI test if the project has one, I will fix it within today.

xuchunyang commented 3 years ago

After upgrade to 20210308.632, it seems that osx-dictionary-search-word-at-point is aliased, and not autoloaded, this is a breaking change for me, perhaps auto load this alias?

Done in the latest commit 4d4cc19fdd4ac8408bd5acc7694e7a7096b1e3b3.