search

xwp / wp-plugin-dependencies

WordPress plugin dependency management.
http://wordpress.org/plugins/plugin-dependencies/
88 stars 16 forks source link

Use yoda conditionals #38

Closed westonruter closed 9 years ago

westonruter commented 9 years ago

This should fix #25.

westonruter commented 9 years ago

@jrfnl you should now have the power to merge PRs.

jrfnl commented 9 years ago

@westonruter Thanks for the heads-up, though it looks like it hasn't gone through yet or maybe it's the group setting ? (pull not push) I appreciate the courtesy and will use it sparingly/with caution.

westonruter commented 9 years ago

Did you receive an invite over email to accept the organization invite?

westonruter commented 9 years ago

@jrfnl woops, try again. I selected Read instead of Write.

jrfnl commented 9 years ago

@westonruter I can see the merge button now. So we should be good ;-)

westonruter commented 9 years ago

Merge away! (If you approve.)

jrfnl commented 9 years ago

@westonruter The PR looks good for what it is. The fact that I detest yoda conditions as they take away from code readability and generally are meant to prevent problems caused by people writing crap code in the first place, is of course a whole other matter ;-)