search

xyzzer / WinRTXamlToolkit

WinRT XAML Toolkit
Other
283 stars 66 forks source link

Fix 'GetDescendants' method will case 'ArgumentException' #45

Closed devkanro closed 7 years ago

devkanro commented 7 years ago

Fix 'GetDescendants' method get child count of 'start', it should be 'parent'.

h82258652 commented 7 years ago

Good, I also create a demo to reproduce this bug. https://github.com/h82258652/WinrtXamlToolkitVisualTreeHelperExtensionsBugDemo

h82258652 commented 7 years ago

@xyzzer hope to see the fixed nuget package as soon as possible.

xyzzer commented 7 years ago

As soon as I have a moment

On Sat, Feb 11, 2017 at 8:17 PM, h82258652 notifications@github.com wrote:

@xyzzer https://github.com/xyzzer hope to see the fixed nuget package as soon as possible.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/xyzzer/WinRTXamlToolkit/pull/45#issuecomment-279195750, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrAsBNgL3Ybg_bmMTWfrqNWBSJAcOVoks5rboe_gaJpZM4L9xy5 .

xyzzer commented 7 years ago

Done

xyzzer commented 7 years ago

It should be done now

h82258652 commented 7 years ago

@xyzzer yes, it works for me now, thanks a million.