search

xyzzer / WinRTXamlToolkit

WinRT XAML Toolkit
Other
282 stars 67 forks source link

NumericUpDown: Default foreground doesn't always match theme #46

Open ionsharp opened 7 years ago

ionsharp commented 7 years ago

If using the dark theme, the foreground is black when not in focus. It should be white like TextBox and then black when in focus. The only way to do this as is would be to explicitly define a style and set the foreground to the appropriate ThemeResource so it displays correctly for all themes.

ionsharp commented 7 years ago

The best ThemeResource to use for this is SystemBaseHighColor because none of the predefined resources for TextBox have ideal values. The closest would be TextBoxBorderThemeBrush, which is #FFFFFFFF for dark and #A3000000 for light.

xyzzer commented 7 years ago

Please send a pull request and I'll integrate it after a review and test.