Missing features from Civ V - G&K

[xlenstra]

This issue is meant as a collection of all G&K features that have not yet been implemented, but we are planning to implement. If you know such a feature that is not listed below, please comment on this thread, and we'll add it to the list.

The old version of this issue can be found as #663, but it contains lots of discussion on issues that have long been solved, cluttering up the issue. Furthermore, multiple new issues have been posted there, but have not been added to the original post. This new issue is meant as a clean slate, including all the open issues from the old version, but leaving all finished baggage behind.

Major things:

• [x] City States - see for examples #4602
• [x] Religion - #4290
• [x] Espionage - #7610
• [x] Score and Time Victory

Units:

• [x] Ranged units may capture civilian units instead of destroying them by moving to their tile
• [x] Capturing civilian units should not cost an attack
• [x] Great people (except great prophets) & work-boats should be destroyed on capture
• [x] Supply cap
• [x] Pillaging of roads when the improvement is already pillaged
• [x] You should not be able to pillage your own tiles
• [x] Pillaging should give gold, based on the improvement pillaged different amounts of gold are plundered
• [x] Barbarians can capture workers/settlers and escort them to encampments. From there they can be liberated, even to other civs. If not liberated, settlers turn into workers upon recapture by a different civ.
• [x] Spawning of barbarian encampments and units in them has other rates in the base game
• [ ] Embarked units should be on a different layer than military and civilian water units. Embarked military and civilian units should be on the same layer.
• [x] Embarked units (except for marines) should have -1 vision
• [x] Spaceship parts should be units, that are added to the spaceship by using an action in the capital
• [x] 'Build road to' action for workers
• [x] 'Remove [feature] and build improvement' action for workers
• [x] Helicopter Gunship has its own unit type: Helicopter (part of greater overhaul of unit types)
• [x] Scouts upgraded through ancient ruins to archers keep the 'no terrain cost' unique (turn it into a promotion)
• [x] Guided missiles should not cost maintenance
• [ ] Great Admiral

Combat:

• [x] Air Sweep action for fighters
• [x] Dogfighting promotion
• [x] Aircraft take damage when attacking
• [x] Submarines should no longer be invisible to enemy civs when there is one of their units next to it
• [x] The +Strength% vs City uniques of most siege units should only be offensive (see #3506)
• [x] Land melee units should not able to capture civilian or attack military units in water and vise versa.
• [ ] Cities should still inflict damage when attacked at 0 hp
• [x] Melee units should enter a city upon capture
• [x] If you recapture your capital, it should become your capital again
• [x] Capturing cities destroys all culture & military buildings in them; other building have a 34% chance of being destroyed
• [x] Recaptured cities should be able to bombard immediately
• [x] Barbarians should not be able to fortify or heal (see #3506)
• [x] Anti-air should deal extra damage to helicopter units
• [x] Accuaracy, Barage (and probably more) should only take effect when attacking (see #4508)
• [x] When defending from a ranged attack, ranged strength should be used (if available) (see #6563)

Diplomacy:

• [ ] Unique quotes for Denouncing
• [ ] Unique quotes for Peace Requests
• [ ] Unique quotes for Friendship Requests
• [ ] A civ can ask another civ to make peace with a third civ
• [x] Enable entering of custom amounts of gold in trade deals
• [x] Remove introducing other empires in trading
• [x] You should not be able to trade away resources gained from trading and/or city-states
• [ ] Many things noted in #4674
• [x] The owner of the UN gets a free vote in all elections

Civs:

• [x] The Celts (reiligion)
• [x] The Maya
• [x] Carthage
• [x] Byzantium (reiligion)
• [x] Austria
• [x] Ethiopia

Cities:

• [x] "Hail The King Day" after acquiring a certain resource for a city
• [x] CN-Tower should provide a free broadcast tower in all cities of the owner of the CN-Tower, so that might change if the city containing it is captured/sold
• [x] ~Border expansion should avoid going into rougher terrain when more open terrain is available~ - won't add.
• [x] Cities on different landmasses can be settled one tile closer together
• [ ] Cities on hills should only cost 1 movement to enter
• [x] Recycling Center
• [x] Annexed cities provide a higher base unhappiness
• [x] Automatic reassignment of population after each turn, with possibly user-set resource focuses (#6144)

Other:

• [X] Zone of Control - #4085
• [x] Oil wells should be named offshore platforms when built on water
• [x] Strategic resources give 2-6 copies of the resource instead of 2 (exact amounts depend on resource) (see #3506)
• [x] Unhappiness effects, such as production debuffs and barbarian units spawning (see #3506)
• [x] Each major civ receives 3 copies of luxury near its starting location (see #3506)
• [ ] Great Person points should be generated per city instead of empirewide (part of greater overhaul of great persons) (see #3506)
• [x] Hills shouldn't give an extra vision bonus
• [x] Forests and jungles should block the view of hills but not of mountains
• [x] Hills, Mountains and most natural wonders may be seen from 1 tile further away than most units can see
• [ ] Multiple civs may play together in a team
• [ ] Completing policy branches give leaders titles
• [x] Notification log
• [x] If a multi-turn move of a unit finishes after pressing 'next turn', you should regain control of your turn to further instruct this unit
• [x] G&K luxuries: Citrus, Crabs, Copper, Truffles, Salt
• [x] G&K natural wonders: Mt. Kailash, Mt. Sinai, Sri Pada, Uluru, Mt. Fuji
• [ ] Wonders providing happiness do so when it is in your border, not necessarily when worked
• [ ] Starting in later era's also slightly decreases tech costs, border culture expansion, tile improvement building time, and a few other things (check game XML files)
• [x] On larger maps, there are more natural wonders
• [ ] On larger maps, unhappiness from the amount of (annexed) cities is slightly decreased
• [x] Replay of the borders of each empire after game end

[ajustsomebody]

this is an absolutely great thread! by any chance you can also link my implementation of diplomacy todo issue?

also please add mountains being able to be seen from away due to height of it like f-fog m-mountain p-plain x-player

ffffffffffffffff ffffffffmffffff ffffffffffffffff pppppppppp pppxpppppp

[ravignir]

Submarines are visible to and can be attacked by enemy units directly next to them

Rather: They are visible to units next to them and can be attacked when visible

[SomeTroglodyte]

Regarding Celts: #4658 only lacked an acceptable implementation of combining positive and negative subfilters into a tileFilter for "unimproved Forest" - I'd like a vision on how to elegantly do that

[xlenstra]

My first idea would be allowing combined filters for tiles as was already done for baseUnits, and then add 'unimproved' as a filter in tileInfo.matchesFilter, which is only true when improvement == null, so you can have something like: "[+1 Faith] from every [City center] adjacent to at least [1] [{unimproved} {Forest}] tiles [in all cities]"

Alternatively, you can do something like "[+1 Faith] from every [City center] adjacent to at least [1] [Forest] tiles without [improvements] [in all cities]", which would require adding "improvement" and "improvements" in improvement.matchesFilter, but is also more moddable, allowing things like "[+2 Food] from every [Forest] adjacent to at least [2] [Forest] tiles without [lumber mill] [in this city]" or something.

[SomeTroglodyte]

You got "and" logic through for unitFilters? My input for logic in tileFilters was summarily rejected back then when I wanted that alien mod improvement to be allowed on any tundra including hill or forest but not other hills or forest - in one unique.

And - oops - that kind of discussion does not belong here. Even the closed 4658 would be the better place. I just wanted that line marked as half-done or something.

[ajustsomebody]

Gold treasure: You receive 50-100  Gold.

Cultural artifacts: You receive 20 Culture.

Religious artifacts: You receive 30-40 Faith.

An ancient prophecy: You receive 80 Faith. Note that the civilization must have founded a Pantheon before this reward becomes possible and that it stops occurring after you've founded a religion.

you should be able to get a random ancient era tech from ruins, you only get ones that you can currently research ( u cnat get calendar without pottery)

barbarian activity spoiled from ancient ruins

all of the bonuses should be adjusted for game speed except for gold

add these too please

[ravignir]

Some of these things may be easily crossed out of the list:

• Hills providing sight bonuses (just json)
• Great person being uncapturable (just json)
• G&K luxuries (i will do it, json + images)

Barbs not healing is already implemented i think (unless they pillage). Do they gain promotions?

Capturing cities destroys all culture buildings in them, and has a chance of destroying additional buildings

I found info on that in civilopedia, it appears that all culture buildings are destroyed, all military buildings are destroyed (barracks etc), all national wonders are destroyed and any other building has 34% chance of being destroyed.

Things to include on the list:

• city always has full combat strength (even if it has 0 hp).
• capturing civilians should not count as an attack (multiple civilians can be captured by a single unit in one turn) and you should capture a civilian when your units move into tile occupied by one (meaning melee unit destroying a military unit protecting a worker, thus moving into its tile, should capture the worker).
• melee unit should enter the city they capture.
• work boats should not be capturable.
• replay functionality; graphs; map timelapse; game log.

[ajustsomebody]

Question: are tiles just at the ends of rivers considered next to river in civ5? as an example:

[SomeTroglodyte]

You've circled 6 tiles - 4x yes, 2x no

[ajustsomebody]

You've circled 6 tiles - 4x yes, 2x no

i dont mean the ones that are directly water tiles, i mean the one with worker and one with hill forest

[ravignir]

Question: are tiles just at the ends of rivers considered next to river in civ5? as an example:

nope

[ajustsomebody]

@xlenstra one thing i wanna add, the happiness from wonders sometimes needs to be worked, it is different per wonder and sometimes it being in your Territory is enough

[xlenstra]

@xlenstra one thing i wanna add, the happiness from wonders sometimes needs to be worked, it is different per wonder and sometimes it being in your Territory is enough

Already on the list

[ajustsomebody]

can you please add the table at the bottom of this link https://civilization.fandom.com/wiki/Map_(Civ5) to the list? especially the natural wonder one is not implemented

[ajustsomebody]

can you add production food science culture output aimed city population assignation to the list? also the cities dont update their assigned population when tile yields change or territory changes (u can improve a farm on a grassland but the game wont move the populstion assigned to s plain grassland to that farm)

[avdstaaij]

According to the wiki, anti-air units and fighters should deal increased damage against Helicopter Gunships.

Anti-air units in particular currently don't do this in Unciv because Helicopter Gunships are implemented as land units and do therefore not match the "air units" unitFilter used in the "+[amount]% Strength vs [air units]" unique. The original game uses the "Bonus vs Aircraft/Helicopters (150)" and "Bonus vs Bomber Units/Helicopters (150)" formulations, but singling out Helicopters is not very modular. Anti-air units and bombers should probably deal increased damage against all free-moving air units, in case mods add more of them. Perhaps we could add a new "hovering" movement type for such units.

[xlenstra]

According to the wiki, anti-air units and fighters should deal increased damage against Helicopter Gunships.

Anti-air units in particular currently don't do this in Unciv because Helicopter Gunships are implemented as land units and do therefore not match the "air units" unitFilter used in the "+[amount]% Strength vs [air units]" unique. The original game uses the "Bonus vs Aircraft/Helicopters (150)" and "Bonus vs Bomber Units/Helicopters (150)" formulations, but singling out Helicopters is not very modular. Anti-air units and bombers should probably deal increased damage against all free-moving air units, in case mods add more of them. Perhaps we could add a new "hovering" movement type for such units.

Helicopter is already a unit type, so I don't feel a specific need for a 'hovering' movement type, especially as it is basically the same as land units in all circumstances (except when you want to make it enter coast tiles without embarking, which was kind of in civ V, but that seems more trouble than its worth). I was already planning on at some point adding Strength bonus vs that unit type to those anti-air units anyway, and I feel like that ought to be fine modularity-wise.

[ajustsomebody]

can u change "Ranged units may capture civilian units instead of destroying them" to you capture civilian units by moving into their tile, this wont use up your attack?

"Automatic reassignment of population after each turn, with possibly user-set resource focuses"

can you change this into when any of the yields within the borders of that city and its shared territory and when that city loses/gains territory (shared included)?

Great people & work-boats should be destroyed on capture

great people minus great prophets, there should instead be a unique that says "gets destroyed when captured" or maybe just "doesn't get destroyed when captured"

[xlenstra]

can u change "Ranged units may capture civilian units instead of destroying them" to you capture civilian units by moving into their tile, this wont use up your attack?

"Automatic reassignment of population after each turn, with possibly user-set resource focuses"

can you change this into when any of the yields within the borders of that city and its shared territory and when that city loses/gains territory (shared included)?

No, because the base game also doesn't do that and this way it is clearer for the user.

Great people & work-boats should be destroyed on capture

there should instead be a unique that says "gets destroyed when captured" or maybe just "doesn't get destroyed when captured"

No, as this is a way of implementing the missing feature, but is not a direct part of this feature itself.

[ravignir]

"Uncapturable" unique already exists (unit is destroyed when you try to capture it) and it is only a matter of editing couple lines in unit.json to make it work like in civ5.

[will-ca]

Some differences:

• Naval units shouldn't have "Sleep until healed" option outside friendly territory if they can't heal.
• Great Person tile improvements should connect strategic and luxury resources.
• Automated workers should replace tile improvements and remove terrain features to connect strategic resources even if improvement replacement is disabled.

[will-ca]

I also noticed that unit maintenance seems fairly steady in the late game, whereas in Civ V it increases quasi-exponentially with the turn count.

However, that's probably one of the worst design choices in Civ: It's clearly a kludge balanced based on only the first couple thousand years, and it makes "forever war" style games both infeasible and unrealistic as gold income eventually stagnates. I think an S-curve that's the same as Civ V's behaviour before levelling off after the endgame could be ideal, or maybe a count based on unit production costs.

[ravignir]

• Great Person tile improvements should connect strategic and luxury resources. nope, not in civ5. Great Improvements connect only strategic resources.

[ajustsomebody]

suggestion for better readability, add max of 3 stars to every element by difficulty to implement, making it look better. like 1 movement points to get into a city center should be 1 star while that border history thing should be like a 2 and 3 for teams

[will-ca]

• Guided missiles shouldn't cost maintenance.
• Civ V prompts for unit orders again after clicking "Next turn" if an automated unit still has MP after finishing its actions, preventing wasted MP.

[ajustsomebody]

distinction of landmasses between them

[ravignir]

Hydro plant building

[xlenstra]

Hydro plant building

Main reason this isn't implemented, is that the AI can't manage its resources, and would spent all of them on building this, thus making it impossible to build modern units

[ajustsomebody]

Hydro plant building

Main reason this isn't implemented, is that the AI can't manage its resources, and would spent all of them on building this, thus making it impossible to build modern units

same with spaceship factories, i cant build a damn rocket artilerry because my cities with low prod decide to construct space age factories in villages

[ravignir]

can you please add the table at the bottom of this link https://civilization.fandom.com/wiki/Map_(Civ5) to the list? especially the natural wonder one is not implemented

It is implemented, but there is a slight problem, let's see if you can spot it; // val numberToSpawn = round(mapRadius 0.13133208f - 0.56128831f).toInt() // fun getHexagonalRadiusForArea(numberOfTiles: Int) = if (numberOfTiles < 1) 0f else ((sqrt(12f numberOfTiles - 3) - 3) / 6) // fun getEquivalentHexagonalRadius(width: Int, height: Int) = getHexagonalRadiusForArea(width * height).roundToInt()

[SomeTroglodyte]

I can spot it! All that code is commented out, so the game won't even compile due to unresolved references! Yay! :partying_face:

[kingkarna1]

• Unhappiness effects, such as production debuffs and barbarian units spawning

ive think a building unique could help with barbarians: "spawns [amount1] [unit] as barbarians at a %[amount2] chance every [amount3] turns when empire has -[amount4] happiness" example: "spawns [3] [warrior] as barbarians at a %[67] chance every [5] turns when empire has -[17] happiness"

[kingkarna1]

• Oil wells should be named offshore platforms when built on water

i think if we have 2 oils(1 for land and 1 for sea, for this land oil is just "Oil" while water oil is "Water Oil") and add a new unique that looks like this: "this resource is the equivalent of [resource]"

it could work

[avdstaaij]

• Oil wells should be named offshore platforms when built on water

i think if we have 2 oils(1 for land and 1 for sea, for this land oil is just "Oil" while water oil is "Water Oil") and add a new unique that looks like this: "this resource is the equivalent of [resource]"

This could work, but a more general solution might be to refactor the improvement system, as discussed in #4889. In particular, see https://github.com/yairm210/Unciv/pull/4889#issuecomment-900961319.

(yes, I still lurk here sometimes)

[will-ca]

The economic/cities overview for Civ V shows the icons of production.

[will-ca]

• Automatic reassignment of population after each turn, with possibly user-set resource focuses

I suggest the first step for focuses should be to support coefficients/weighting for different resource types in population assignment.

[foolishgrunt]

Would it be possible to also list missing features that are "wontfix" and "wontfix until [X] happens"?

Example of "wontfix": Naval and land units cannot co-occupy city

Example of "wontfix until [X] happens": Hydo plant will not be implemented until AI learns to manage resources

[foolishgrunt]

Great person points should be accrued on a per-city basis, not empire-wide.

[xlenstra]

Great person points should be accrued on a per-city basis, not empire-wide.

Already on the list

[will-ca]

IIRC: Civ V clearly shows which units are (defenceless) civilians by drawing their icons in a different shape. In Civ V they are triangular.

This clearly communicates to the player which units are okay to send into combat and the like, and probably eases the learning curve. I didn't even notice it since I already knew that from Civ V, but I can see how poor distinguishability would be confusing to a new player. (See: #5689.)

[will-ca]

Consensus in results exposed by Google is that even the basic nuke can't actually be intercepted in Civ V.

https://github.com/yairm210/Unciv/blob/af941754cdd513cd80d13fb820083de9ceda5387/core/src/com/unciv/logic/battle/Battle.kt#L625-L635

It's not clear whether that's by design, or a bug/incomplete feature in Civ V, though.

[xlenstra]

Consensus in results exposed by Google is that even the basic nuke can't actually be intercepted in Civ V.

https://github.com/yairm210/Unciv/blob/af941754cdd513cd80d13fb820083de9ceda5387/core/src/com/unciv/logic/battle/Battle.kt#L625-L635

It's not clear whether that's by design, or a bug/incomplete feature in Civ V, though.

If I'm not mistaken, when I implemented this, it was marked as a bug that this was impossible. It's been a few months since I looked at the civ 5 source code, but iirc, atomic bombers are actually marked as interceptable, but as they are handled differently from all other air units, the function doing the interception is never called. I've chosen to actually implement this, both to fix this "bug" and to give some defence against at least the first level nukes.

[itanasi]

Several of these can get checked off.

See #6128 #5975 #5974

[itanasi]

Unemployed Citizens should contribute 1 Hammer and count as a Specialist

[xlenstra]

Unemployed Citizens should contribute 1 Hammer

I'm 90% certain this is already implemented

and count as a Specialist

Does this actually matter for anything? It feels like a weird choice to me, 'Your specialization is not doing anything'? It seems more to me it was an implementation detail resulting in every pop being either a specialist or working a tile, which could streamline some calculations but we've already worked around that?

[itanasi]

Looks like the +1 Production is in. Counting as Specialists matters mainly for the Food or Happiness bonuses from stuff like Policy (Civil Society) or Wonder (Statue of Liberty)

[xlenstra]

Looks like the +1 Production is in. Counting as Specialists matters mainly for the Food or Happiness bonuses from stuff like Policy (Civil Society) or Wonder (Statue of Liberty)

Tested it ingame and this indeed seems to be the case, yet it feels weird to call unemployed people 'specialists'. Another option would be to add 'unemployed' as a populationFilter, and the uniques for Civil Society and Statue of Liberty can be expanded to include another unique for that. Does anyone have a preference?

[ravignir]

Tested it ingame and this indeed seems to be the case, yet it feels weird to call unemployed people 'specialists'. Another option would be to add 'unemployed' as a populationFilter, and the uniques for Civil Society and Statue of Liberty can be expanded to include another unique for that. Does anyone have a preference?

have you tested it in all possible configurations? Vanilla/G&K/BNW. I am getting weird results.

BNW nad G&K: Unemployed citizen is just unemployed citizen - not affected by Korean/Secularism ability, half specialist Food consumption policy, Statue of Liberty (despite it says it provides 2 Production, the yield does not change!).

Vanilla: Affected by Secularism, Food thing and Statue. Not affected by Korean ability (but i found info it used to).

[xlenstra]

I've only tested it with the Civil Society and Democracy policies in G&K, as that was the easiest to set up, and they both worked so I assumed it would be consistent

[alexban01]

Notification log

you can mark that as done now :)

Actually there are a few more