Gradle assemble doesn't generate MANIFEST.MF correctly

yasuflatland-lf / liferay-dummy-factory

🏭 Liferay DXP / 7 Dummy data generation portlet

MIT License

49 stars 35 forks source link

Gradle assemble doesn't generate MANIFEST.MF correctly #27

Closed rodrigopaulino closed 5 years ago

rodrigopaulino commented 6 years ago

When I run gradle clean assemble at the root folder of the repo, the built build/libs/liferay-dummy-factory.jar doesn't contain all the bundle's properties (i.e. Bundle-Name, Bundle-SymbolicName, Import-Package etc). I'm using the gradle committed in this repo and I've tried with more than one branch: master, 7.1.x, tag/0.16.

yasuflatland-lf commented 6 years ago

@rodrigopaulino Thank you for reporting this. Let me confirm, does "'I'm using the gradle committed in this repo" means using gradlew clean assemble?

rodrigopaulino commented 6 years ago

Yes. That is correct

yasuflatland-lf commented 6 years ago

@rodrigopaulino , please checkout 7.1.x and git id 19650d73c64238288a3b8ff0a64c279af196390a, and run gradlew clean assemble should create a bundle properly.

rodrigopaulino commented 6 years ago

Hey, @yasuflatland-lf.

I believe that you have to set the version of some dependencies for ones that are already released in build.gradle. See attached log.txt

yasuflatland-lf commented 6 years ago

@rodrigopaulino Please try this. I could successfully build and deploy with this steps below from scratch.

Install Blade (https://dev.liferay.com/ja/develop/tutorials/-/knowledge_base/7-0/blade-cli)
Clone liferay-portal repository, checkout master and run ant all. It'll create bundles directory.
Under the ${HOME}/.gradle , those missing jars you pointed out should be created.
Start up Liferay server under bundles directory that you just built.
Go to the liferay workspace where dummy factory is placed and go to the dummy factory root directory and run blade deploy.

Also I could successfully build a bundle with gradlew deploy