yearn / seafood

Seafood
https://seafood.yearn.watch
13 stars 21 forks source link

Etouffee upgrade #154

Closed murderteeth closed 1 year ago

murderteeth commented 1 year ago
vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seafood ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2023 3:26am
newmickymousse commented 1 year ago

A few things:

  1. Ethereum vaults show $0 TVL.

    Screenshot 2023-05-22 at 6 17 48 PM
  2. is there a way to add a filter, to filer old vaults in term of api version? Like show only latests vaults, unless you specifically chooes to show older vaults too.

  3. Why is it showing fantom vaults first and not ethereum vaults?

    Screenshot 2023-05-22 at 6 19 13 PM

The rest looks good and nice. Very clean version.

murderteeth commented 1 year ago

@newmickymousse 1 - TVL problems are fixed. 2 - Added "V1" and "V2" options to the Vaults filter (see below). I have it this way: V2 for vaults >= 0.4, V1 for vaults < 0.4 3 - Related to problem 1. Vaults are sorted by TVL descending. But vault TVLs for eth, arb, and opt were coming back zero while fantom TVLs were still working. So the fantom vaults were getting sorted on top of everything else.

image

newmickymousse commented 1 year ago

LGTM