search

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.
Other
22 stars 7 forks source link

Fix `near me` searches sometimes not triggering HTML5 geolocation #1809

Closed oshi97 closed 1 year ago

oshi97 commented 1 year ago

This PR updates the SDK to the latest version of core, which has been updated to include inputIntents on search-core's AutocompleteResult that were expected by the SDK but did not exist before.

search-core has been updated from v1.6 to v2.2, however none of the breaking changes affect the SDK's external interfaces. The SDK's internal filter registry has been updated to support the breaking static filter changes from v2.0 of search-core.

T=TECHOPS-8462 TEST=auto,manual

hook local SDK up to affected techops site. see that geolocation now fires for edge case where a user clicks on an autocomplete option for a "near me" search as opposed to typing it out manually.

see that selecting a single static filter works as expected multiple static filters from the same field works as expected (are $or-ed together) and multiple static filters from different fields works as expected (are $and-ed together)

coveralls commented 1 year ago

Coverage Status

Coverage: 61.441% (+0.002%) from 61.439% when pulling ac44769f7e21e4a5461252260f72dbfa599d7614 on dev/missing-autocomplete-input-intents into 3ab4bcad93528b704ef53a6d0b7938cd4950579d on hotfix/v1.15.4.