search

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.
Other
22 stars 7 forks source link

wcag: use appropriate aria roles for search input #1814

Closed benmcginnis closed 1 year ago

benmcginnis commented 1 year ago

A customer noticed that we had an aria-expanded attribute on the search input, which they flagged as incorrect. Based on https://w3c.github.io/aria/#combobox, it appears we need to use the combobox role on the input element and search on the form element.

J=TECHOPS-8758 TEST=auto

Reran acceptance tests

coveralls commented 1 year ago

Coverage Status

Coverage: 61.441%. Remained the same when pulling 6a23563f9788e9b8928bd37c157195a2e885a3dd on hotfix/v1.15.5 into 83b13ad7df525249f40e163fa54b10800e60e021 on master.