search

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.
Other
22 stars 7 forks source link

Upgrade @babel/traverse #1851

Closed nmanu1 closed 10 months ago

nmanu1 commented 10 months ago

Upgrade @babel/traverse from v7.17.10 to 7.23.5 to address a critical vulnerability in the package.

J=VULN-38480 TEST=auto

coveralls commented 10 months ago

Coverage Status

coverage: 61.411%. remained the same when pulling 132a682db644f0ba3d11e13a66f20b1841bf52ae on dev/babel-traverse-vulnerability into 0f8a1a655b5c9a23cc528bc3357902f3702dc156 on hotfix/v1.16.5.

nmanu1 commented 10 months ago

lgtm, but do we need to set the version in the package.json or are we just relying on the package lock?

it's a transitive dependency, so we don't currently specify a version in our package.json

benmcginnis commented 10 months ago

Ah ok great