search

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.
Other
22 stars 7 forks source link

Bump browserify-sign to v4.2.3 #1869

Closed EmilyZhang777 closed 7 months ago

EmilyZhang777 commented 7 months ago

Bump browserify-sign to v4.2.3 to resolve a vulnerability.

J=VULN-38744 TEST=auto,manual

Ran npm run test and npm run acceptance. Ran npx serve -p 9999 and clicked around.

coveralls commented 7 months ago

Coverage Status

coverage: 62.02%. remained the same when pulling b9ea30a561cfb649a3e8cc0b871484a9245519cb on dev/vulnerabilities-2 into 66fef3086dfae095ee93cfb41ecb0792be1d637b on master.

EmilyZhang777 commented 7 months ago

did you also check that running the build and using the generated bundles in the Theme test site was fine? it looks like browserify-sign is dep of a library we use for bundling, so it would affect our build step

yep! Tested HH theme still works with a local build.