Fix Filter Options Highlighting

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.

Other

22 stars 7 forks source link

Fix Filter Options Highlighting #1871

Closed EmilyZhang777 closed 7 months ago

EmilyZhang777 commented 7 months ago

Previously, when we moved from innerHTML to textContent, it broke the filter options highlighting since the <strong> tag is no longer applied properly. This PR fixes the issue while still avoid insecure document method.

J=TECHOPS-11319 TEST=auto, manual

Ran npm run test. Serve answers-search-ui locally and checked out hh theme. Made sure the highlighting are working. https://drive.google.com/file/d/1lBVOA759BPwsqmENIv6kFe2FasR25EKO/view?usp=sharing

coveralls commented 7 months ago

coverage: 62.092% (+0.07%) from 62.02% when pulling 6c6f8ca7f2dda38523d51c3f385e42219f632398 on dev/fix-filter-options into bd429a25b0fd63deea864a61200328d404cd1163 on hotfix/v1.17.1.

EmilyZhang777 commented 7 months ago

can you add some screenshots/recording of what it looks like? also, can you provide a little more detail in the PR description?

Added more details and a screenshot.