We added two new jobs: merge_multiple_artifacts and overwrite_artifact in .github/workflows/build_i18n.yml to handle merging multiple locale files into the build-output-US and build-output-EU artifacts. This was necessary since we have to handle no longer being able to have multiple jobs in the same workflow write to one artifact name and mutate it, a breaking change in action/upload-artifact@v4. Since build_and_deploy_i18n.yml calls both build.yml and build_i18n.yml, we can't have both write an artifact called build-output-US unless we pass the overwrite: true input in the latter. The action/upload-artifact/merge@v4 doesn't allow overwriting, so we need an additional step of merging and uploading with a temporary name and then downloading the merged artifact and re-uploading to overwrite the correct name.
We bumped google-github-actions/auth and google-github-actions/upload-cloud-storage from v0 to v2
Updated actions/checkout, actions/setup-node, actions/upload-artifact, actions/download-artifact, and aws-actions/configure-aws-credentials actions to v4
Testing was done in a forked repo. View actions to see testing details and test commits. We also checked the US/EU build artifact unzipped files to ensure they are uploaded to AWS/GCP properly and that they look similar to build files prior to this update. Finally, we did local testing from the Answers-Hitchhiker-Theme repo's test site that pointed to our dev assets in AWS. The dev bucket in GCP did not have the correct permissions to allow local testing, so this local testing will be done after merging this PR and the changes from develop are pushed to canary in GCP.
coverage: 62.092%. remained the same
when pulling 856f988742329a2d04b50c6111366879896314c2 on dev/update-workflow
into ee4333d6264ece2370d1472aca20087ed05e50d1 on develop.
Notable Changes:
We added two new jobs:
merge_multiple_artifacts
andoverwrite_artifact
in.github/workflows/build_i18n.yml
to handle merging multiple locale files into thebuild-output-US
andbuild-output-EU
artifacts. This was necessary since we have to handle no longer being able to have multiple jobs in the same workflow write to one artifact name and mutate it, a breaking change inaction/upload-artifact@v4
. Sincebuild_and_deploy_i18n.yml
calls bothbuild.yml
andbuild_i18n.yml
, we can't have both write an artifact calledbuild-output-US
unless we pass theoverwrite: true
input in the latter. Theaction/upload-artifact/merge@v4
doesn't allow overwriting, so we need an additional step of merging and uploading with a temporary name and then downloading the merged artifact and re-uploading to overwrite the correct name.We bumped
google-github-actions/auth
andgoogle-github-actions/upload-cloud-storage
from v0 to v2Updated
actions/checkout
,actions/setup-node
,actions/upload-artifact
,actions/download-artifact
, andaws-actions/configure-aws-credentials
actions to v4J=WAT-4020 TEST=manual
Testing was done in a forked repo. View actions to see testing details and test commits. We also checked the US/EU build artifact unzipped files to ensure they are uploaded to AWS/GCP properly and that they look similar to build files prior to this update. Finally, we did local testing from the Answers-Hitchhiker-Theme repo's test site that pointed to our dev assets in AWS. The
dev
bucket in GCP did not have the correct permissions to allow local testing, so this local testing will be done after merging this PR and the changes from develop are pushed tocanary
in GCP.