search

yext / answers-search-ui

Answers Javascript API Library for building Search experiences.
Other
22 stars 7 forks source link

Answers SDK: add cloudChoice support #1896

Closed Fondryext closed 1 month ago

Fondryext commented 1 month ago

Now that cloudChoice is a param inside of search-core, this CR adds support for setting it in the SDK, in the init() function, including setting the old behavior as the default. It is not needed elsewhere like with the CLOUD_REGION setting, as that is used for things like analytics tracking.

J=WAT-4375 TEST=auto

Ran test suite

Fondryext commented 1 month ago

Honestly not too familiar with manual testing of just the SDK. Willing to look into it, but figured I'd put this up since it's smaller and also I'm heading out early today.

coveralls commented 1 month ago

Coverage Status

coverage: 62.127% (+0.01%) from 62.114% when pulling 4e0d924f9e4589b6dd1327bda8b13fc5de39a18e on dev/v1.17.5 into 2725725340207a82cc4416150378ddfba4e7fd9e on hotfix/v1.17.5.